Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework make_filter interface to accept either size_px or radius and d… #1776

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

yaugenst-flex
Copy link
Collaborator

…l arguments, import all user-facing functions into the plugins/autograd namespace, and add tests

Closes #1775

@yaugenst-flex yaugenst-flex requested a review from tylerflex June 19, 2024 15:00
@yaugenst-flex yaugenst-flex force-pushed the yaugenst-flex/autograd-utilities branch from 41d0ba0 to 46b6f2e Compare June 19, 2024 15:06
Copy link
Collaborator

@tylerflex tylerflex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yaugenst . Looks good overall, a few details.
The main thing to discuss is the fact that this breaks backwards compabibility with the size -> size_px change. What are your thoughts on that? is autograd so experimental that we can do this safely?

@yaugenst-flex yaugenst-flex force-pushed the yaugenst-flex/autograd-utilities branch from 46b6f2e to 0923c79 Compare June 19, 2024 15:09
@yaugenst-flex
Copy link
Collaborator Author

The main thing to discuss is the fact that this breaks backwards compabibility with the size -> size_px change. What are your thoughts on that? is autograd so experimental that we can do this safely?

Yeah this is pretty unfortunate, but size is I think too ambiguous... I think (I hope) it's fine? I'm sure there will be other breaking changes too...

@yaugenst-flex yaugenst-flex force-pushed the yaugenst-flex/autograd-utilities branch from c145880 to 99c0cab Compare June 28, 2024 14:33
@tylerflex
Copy link
Collaborator

Let's change target of this to pre/2.8?

@yaugenst-flex yaugenst-flex changed the base branch from develop to pre/2.8 June 28, 2024 14:39
@yaugenst-flex
Copy link
Collaborator Author

Oh yeah was just in the process of doing that :)

@yaugenst-flex yaugenst-flex force-pushed the yaugenst-flex/autograd-utilities branch from 99c0cab to 744f377 Compare July 1, 2024 10:29
@yaugenst-flex yaugenst-flex self-assigned this Jul 2, 2024
@yaugenst-flex yaugenst-flex force-pushed the yaugenst-flex/autograd-utilities branch from 744f377 to 0ab7d2c Compare July 8, 2024 14:21
@yaugenst-flex yaugenst-flex requested a review from tylerflex July 9, 2024 16:51
@yaugenst-flex yaugenst-flex force-pushed the yaugenst-flex/autograd-utilities branch from ff9f499 to 898f4c2 Compare July 9, 2024 16:57
Copy link
Collaborator

@tylerflex tylerflex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good.

I'm having trouble visualizing the API / if there are any changes? especially to invdes? does it break backwards compatibility?

I also think it would make some sense to define the default parameters, especially for beta, as constants somewhere so we can tweak them more easily.

Thanks @yaugenst-flex

@yaugenst-flex
Copy link
Collaborator Author

I'm having trouble visualizing the API / if there are any changes? especially to invdes? does it break backwards compatibility?

It doesn't break backwards compatibility, no, only if we decide to get rid of the functional interface altogether.

@tylerflex
Copy link
Collaborator

let's leave the functional interface but introduce these new classes and maybe change notebooks to use the classes?

@tylerflex
Copy link
Collaborator

@yaugenst-flex just checking, where did we leave off with this PR? are you waiting for my review?

@yaugenst-flex
Copy link
Collaborator Author

I thin it was most of the way there, some unresolved things regarding the class constructors for the filters, but I'll finish it up and you can review again, this should be done for 2.8

@yaugenst-flex yaugenst-flex added the 2.8 will go into version 2.8.* label Aug 29, 2024
@yaugenst-flex yaugenst-flex force-pushed the yaugenst-flex/autograd-utilities branch from 7d2817a to dc465e2 Compare August 29, 2024 14:12
@tylerflex tylerflex mentioned this pull request Sep 3, 2024
11 tasks
@yaugenst-flex yaugenst-flex force-pushed the yaugenst-flex/autograd-utilities branch from dc465e2 to 360ec7e Compare September 24, 2024 17:26
@yaugenst-flex yaugenst-flex changed the base branch from pre/2.8 to develop September 24, 2024 17:26
@yaugenst-flex
Copy link
Collaborator Author

yaugenst-flex commented Sep 24, 2024

@momchil-flex this is actually backwards compatible and does not require changes to the notebooks I'll run some to be sure but In principle the notebooks can be updated later -> nope

see flexcompute/tidy3d-notebooks#174

…l arguments, import all user-facing functions into the plugins/autograd namespace, add class-based penalties and parametrizations
@momchil-flex momchil-flex force-pushed the yaugenst-flex/autograd-utilities branch from e2fa59e to 1709b28 Compare September 25, 2024 13:25
@momchil-flex momchil-flex merged commit 9c88c53 into develop Sep 25, 2024
15 checks passed
@momchil-flex momchil-flex deleted the yaugenst-flex/autograd-utilities branch September 25, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.8 will go into version 2.8.*
Projects
None yet
Development

Successfully merging this pull request may close these issues.

autograd utilities interface changes
3 participants