-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework make_filter interface to accept either size_px or radius and d… #1776
Conversation
41d0ba0
to
46b6f2e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @yaugenst . Looks good overall, a few details.
The main thing to discuss is the fact that this breaks backwards compabibility with the size
-> size_px
change. What are your thoughts on that? is autograd
so experimental that we can do this safely?
46b6f2e
to
0923c79
Compare
Yeah this is pretty unfortunate, but |
c145880
to
99c0cab
Compare
Let's change target of this to pre/2.8? |
Oh yeah was just in the process of doing that :) |
99c0cab
to
744f377
Compare
744f377
to
0ab7d2c
Compare
ff9f499
to
898f4c2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good.
I'm having trouble visualizing the API / if there are any changes? especially to invdes? does it break backwards compatibility?
I also think it would make some sense to define the default parameters, especially for beta, as constants somewhere so we can tweak them more easily.
Thanks @yaugenst-flex
It doesn't break backwards compatibility, no, only if we decide to get rid of the functional interface altogether. |
let's leave the functional interface but introduce these new classes and maybe change notebooks to use the classes? |
@yaugenst-flex just checking, where did we leave off with this PR? are you waiting for my review? |
I thin it was most of the way there, some unresolved things regarding the class constructors for the filters, but I'll finish it up and you can review again, this should be done for 2.8 |
7d2817a
to
dc465e2
Compare
dc465e2
to
360ec7e
Compare
@momchil-flex |
…l arguments, import all user-facing functions into the plugins/autograd namespace, add class-based penalties and parametrizations
e2fa59e
to
1709b28
Compare
…l arguments, import all user-facing functions into the plugins/autograd namespace, and add tests
Closes #1775