Bringing in upgraded mode solver #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerflex
reviewed
Jan 28, 2022
lint.py
Outdated
| @@ -35,7 +35,7 @@ def main(): | |||
|
|
|||
| results = Run([path], do_exit=False) | |||
|
|
|||
| final_score = results.linter.stats.global_note | |||
| final_score = results.linter.stats["global_note"] | |||
There was a problem hiding this comment.
this was changed to . syntax because it errored before.
tylerflex
reviewed
Jan 28, 2022
tidy3d/components/mode.py
Outdated
| bend_radius: float = pd.Field( | ||
| None, | ||
| title="Bend radius", | ||
| description="A curvature radius for simulation of waveguide bends.", |
There was a problem hiding this comment.
maybe add that negative curvature means it bends downwards?
Latest solver updates from old tidy3d bend modes in ModeSpec Mode solver always takes grid boundaries instead of grid_size so that it works with nonuniform coords Changed structure close to PML warning a bit
45c534b to
f5384a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Latest solver updates from old tidy3d
bend modes in ModeSpec
Mode solver always takes grid boundaries instead of grid_size so that it works with nonuniform coords