Fix to mesher error in very specific cases #1325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6804132 to
4133112
Compare
tidy3d/components/grid/mesher.py
Outdated
|
|
||
| To build this, we iterate in reverse order as latter structures override earlier ones. | ||
| We also handle containment in the following way (note - we work with bounding boxes only): | ||
| 1. If a structure that is lower in the list than the current structure is found to be |
There was a problem hiding this comment.
There is a duplicated space here.
weiliangjin2021
approved these changes
Dec 19, 2023
03ad161 to
c98b3cd
Compare
Warn when structures are too small compared to the generated mesh
c98b3cd to
dfbbb44
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warn when structures are too small compared to the generated mesh.
Also realized that e.g. placing a thin
MeshOverrideStructureof size dl and mesh step dl will not place boundaries on both sides of that structure (i.e. a single mesh step) because of the way theisclosecheck is done. Changed tolerances a bit to fix this as it should be expected behavior.I also added more docstrings explaining how that part of the mesher works. I must admit it's still a bit of a mess, but I don't have time for a complete overhaul (and it's not clear what that might look like).