Mode solver eps_complex check at central frequency only #1312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tidy3d/plugins/mode/mode_solver.py
Outdated
| for int_mat in self._intersecting_media: | ||
| max_imag_eps = np.amax(np.abs(np.imag(int_mat.eps_model(np.array(self.freqs))))) | ||
| max_imag_eps = np.amax(np.abs(np.imag(int_mat.eps_model(freq0)))) | ||
| if not np.isclose(max_imag_eps, 0): |
There was a problem hiding this comment.
np.isclose to math.isclose?
1d14095 to
ac0211f
Compare
I fixed that here: #1290
Updated and also using math.isclose. |
ac0211f to
66fc51c
Compare
weiliangjin2021
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whether
eps_modelworks with an array of frequencies is not consistent among the various media. Earlier I had an issue with fully anisotropic which I fixed, but now I see that the same is true for (some?) custom media. Since fully clarifying that may be a mess, and for this particular check looking at the central freqeuncy is probably fine, I propose this change for now.Of course I could also iterate over
freqs, but I want this check to be very fast even in cases with e.g. large custom media / many freqs, so I chose not to.