Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unpin boto and click #1210

Merged
merged 1 commit into from
Oct 20, 2023
Merged

unpin boto and click #1210

merged 1 commit into from
Oct 20, 2023

Conversation

tylerflex
Copy link
Collaborator

This unpins the versions of boto and click, see #1209

I tested with our webapi notebook with

click==8.0.3
boto3==1.23.1

and it worked fine

@magiWei do you see any issues with this?

@tylerflex tylerflex mentioned this pull request Oct 18, 2023
@tylerflex tylerflex force-pushed the tyler/web/unpin_boto_click branch 2 times, most recently from b810802 to 286a654 Compare October 19, 2023 14:49
@tylerflex tylerflex changed the base branch from develop to pre/2.5 October 19, 2023 14:49
@tylerflex tylerflex added the 2.5 label Oct 19, 2023
@tylerflex tylerflex requested review from dbochkov-flexcompute and removed request for lei-flex and QingengWei October 19, 2023 14:50
@tylerflex
Copy link
Collaborator Author

@dbochkov-flexcompute based on some discussion on Lark and also #1209 , maybe we can try updating these versions and testing a bit more in the pre/2.5 releases. I tried already with basic webapi notebooks and it works fine, but might be good to be extra sure before officially releasing

@tylerflex tylerflex force-pushed the tyler/web/unpin_boto_click branch 3 times, most recently from 3c0c930 to d0198cd Compare October 19, 2023 14:59
@tylerflex tylerflex force-pushed the tyler/web/unpin_boto_click branch from d0198cd to e038696 Compare October 19, 2023 15:09
Copy link
Collaborator

@lei-flex lei-flex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ship it.

@tylerflex tylerflex merged commit a813f9d into pre/2.5 Oct 20, 2023
@tylerflex tylerflex deleted the tyler/web/unpin_boto_click branch October 20, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants