-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adapt to AWS lambda environment #1100
Conversation
82b1d07
to
621fdb9
Compare
Changes for hdf5 handling look good. Please revert all changes related to the config file, they are not needed and are also making the tests fail (can't import from tidy3d in setup.py). I will test once these changes are reverted and merge if all good. |
config file? which one? |
621fdb9
to
d51a0c8
Compare
Revert all the changes related to |
so, if user cannot write ~/.tidy3d, they use os.enviroment? |
d51a0c8
to
e8ab568
Compare
Yes. However, this makes me realize something: when we had user name and password authentication, the user was asked whether they want to store credentials to file. Now it seems like if user does @lei-flex what do you think? |
e8ab568
to
57cb350
Compare
This is my concern, if the user needs to use username/pwd, f"{expanduser('~')}/.tidy3d" can't be writted on lambda, so I add one "/tmp/.tidy3d" TIDY3D_DIR = f"{expanduser('~')}/.tidy3d" |
Ok let's keep this part as long as you don't have to import anything in setup.py. |
Note tests are failing currently. |
0166f51
to
a056231
Compare
tests are ok now, Do we need add one test about lambda function. |
How can we test it? If possible to mock then yeah why not. |
I test it on https://github.com/flexcompute/tidy3d-python-webapi, add one new release-xxx and write one api, then deploy to lambda, |
039454b
to
ab29beb
Compare
ab29beb
to
4d552fc
Compare
No description provided.