Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added warnings for source / medium frq ranges and grid size #110

Merged
merged 6 commits into from
Jan 21, 2022
Merged

added warnings for source / medium frq ranges and grid size #110

merged 6 commits into from
Jan 21, 2022

Conversation

tylerflex
Copy link
Collaborator

  • Warns if any medium has a frequency range that does not fully cover those of all of the sources.
  • For each source and medium, warns if any of the (uniform / float-like) grid sizes are greater than λ0 / n / 6 with λ0 being the average frequency of the source and n=n(λ0) is the refractive index of the medium. 6 is a tunable parameter defined as a constant in simulation.py

@tylerflex
Copy link
Collaborator Author

Fixes #108

@tylerflex tylerflex requested a review from twhughes January 5, 2022 18:12
@tylerflex tylerflex merged commit 7d5a152 into develop Jan 21, 2022
@tylerflex tylerflex deleted the sim_validations branch March 25, 2022 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@momchil-flex momchil-flex Awaiting requested review from momchil-flex

@twhughes twhughes Awaiting requested review from twhughes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tylerflex