adapt to AWS lambda environment #1099
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on surfaces are outside of the domain
fix: plot 3d format
…e source or monitors
…em variable is not empty
updated changelog
Added reference for Germanium material model from Burnett et al.
- updated based on PR comments
* Use pytest's tmp path instead of hard-codded ones Hard-codded paths can be an issue when tests are run in parallel or unordered, particularly in Windows. This commit removes all hard-codded paths from the test suite, replacing them with pytest's tmp_path fixture, which is also automatically cleaned after run. A few ruff warnings were also cleaned up in the process: mostly unused imports and variables, and warnings caused by a large number of matplotlib figures being created. --------- Signed-off-by: Lucas Heitzmann Gabrielli <lucas@flexcompute.com>
Also, allow GeometryGroup to accept GeometryGroup instances as group elements. That's because ClipOperation must accept them as operands, so it makes sense to extend the support to GeometryGroup, since the backend code is already in place. Importing a general gds file requires the implementation of `ComplexPolySlab`, but the plugin implementation depends on `Medium` and `Structure` for the `to_structure` method, so it cannot be simply refactored into the geometry namespace. The solution was to have a base class without the problematic method in geometry, which can be used to import gds files. Signed-off-by: Lucas Heitzmann Gabrielli <lucas@flexcompute.com>
Only `GeometryType` and `from_shapely` remain as problematic objects beacuse they require cyclic imports. Signed-off-by: Lucas Heitzmann Gabrielli <lucas@flexcompute.com>
Use the same grid size for both when loading vertices from GDSII, and apply dilations in the same manner to avoid unexpected differences due to operation order. Signed-off-by: Lucas Heitzmann Gabrielli <lucas@flexcompute.com>
Signed-off-by: Lucas Heitzmann Gabrielli <lucas@flexcompute.com>
Fixes the issue raised in flexcompute/tidy3d-core#375 (comment) by looking for geometry datasets in nested geometries. Error if a structure contains a large number of nested geometries, as preprocessing performance in the backend degrades rapidly in this case. Signed-off-by: Lucas Heitzmann Gabrielli <lucas@flexcompute.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.