Adding tests of computed medium epsilon vs expected #103
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ported some tests that compare expected epsilon from various medium initializations. This revealed one issue with the conductivity, in that
EPSILON_0
was missing. Perhaps there was some logic to that change, and we can revert to the original file (and change the conductivity in the test to0.1 / EPSILON_0
), but then we have to change the docstrings, because the conductivity will no longer be in units ofS/micron
.The docstrings are correct w.r.t. the current change, but they are a bit confusing. When we say
We don't mean the relative complex permittivity; we mean the one in SI units. So the imaginary part of the relative permittivity is given by
conductivity / omega / EPSILON_0
.