Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding tests of computed medium epsilon vs expected #103

Merged
merged 2 commits into from
Dec 10, 2021

Conversation

momchil-flex
Copy link
Collaborator

I ported some tests that compare expected epsilon from various medium initializations. This revealed one issue with the conductivity, in that EPSILON_0 was missing. Perhaps there was some logic to that change, and we can revert to the original file (and change the conductivity in the test to 0.1 / EPSILON_0), but then we have to change the docstrings, because the conductivity will no longer be in units of S/micron.

The docstrings are correct w.r.t. the current change, but they are a bit confusing. When we say

        Defined such that the imaginary part of the complex permittivity at angular frequency omega
        is given by conductivity/omega.

We don't mean the relative complex permittivity; we mean the one in SI units. So the imaginary part of the relative permittivity is given by conductivity / omega / EPSILON_0.

@momchil-flex momchil-flex merged commit 2d2d589 into develop Dec 10, 2021
@momchil-flex momchil-flex deleted the medium_test branch December 10, 2021 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant