Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed import and plotting of trimesh.Scene #1018

Merged
merged 1 commit into from
Jul 19, 2023
Merged

Fixed import and plotting of trimesh.Scene #1018

merged 1 commit into from
Jul 19, 2023

Conversation

caseyflex
Copy link
Contributor

No description provided.

@caseyflex caseyflex requested review from tylerflex and xin-flex July 18, 2023 22:37
tylerflex
tylerflex reviewed Jul 18, 2023
View reviewed changes
Copy link
Collaborator

@tylerflex tylerflex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we have a test that catches this?

@caseyflex caseyflex force-pushed the casey/fixstlscene branch from 666fc79 to 29ad7c9 Compare July 19, 2023 00:03
@caseyflex
Copy link
Contributor Author

do we have a test that catches this?

Added a test and trimesh.Scene STL to SIM_FULL

xin-flex
xin-flex approved these changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@xin-flex xin-flex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue has been resolved.

@tylerflex tylerflex merged commit 264a745 into pre/2.4 Jul 19, 2023
@tylerflex tylerflex deleted the casey/fixstlscene branch July 19, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tylerflex tylerflex tylerflex approved these changes

@xin-flex xin-flex xin-flex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@caseyflex @tylerflex @xin-flex