Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating surface integration validator to only error if all integrati… #1017

Merged
merged 1 commit into from
Jul 19, 2023

Conversation

momchil-flex
Copy link
Collaborator

@momchil-flex momchil-flex commented Jul 18, 2023

…on surfaces are outside of the domain

It is actually convenient in some cases for the user to place a box that's partly outside of the domain without having to explicitly exclude the surfaces. The solver works as long as there's any part that's inside the domain. We could also fix the solver to work if everything is outside, but in that case probably the monitor was incorrectly set up.

@momchil-flex momchil-flex requested a review from shashwat-sh July 18, 2023 21:02
Copy link
Contributor

@shashwat-sh shashwat-sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good but won't we get an out-of-domain error anyway for any component completely outside the domain?

@momchil-flex
Copy link
Collaborator Author

The original problem was a 3D monitor that's larger than the simulation domain, such that it covers the simulation, but all of its surfaces are outside of it. This doesn't trigger the usual warning. This update would error in this case, as well as in more esoteric cases where e.g. some of the surfaces do cross the simulation domain, but those are excluded in exclude_surface.

@momchil-flex momchil-flex merged commit eae94bf into develop Jul 19, 2023
@momchil-flex momchil-flex deleted the momchil/surface_integration_validator branch July 19, 2023 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants