Skip to content

Commit

Permalink
run time required again, not validated pre-init
Browse files Browse the repository at this point in the history
  • Loading branch information
tylerflex committed Mar 28, 2022
1 parent dd07a39 commit 2074ed7
Showing 1 changed file with 4 additions and 5 deletions.
9 changes: 4 additions & 5 deletions tidy3d/components/simulation.py
Original file line number Diff line number Diff line change
Expand Up @@ -103,13 +103,12 @@ class Simulation(Box): # pylint:disable=too-many-public-methods
units=MICROMETER,
)

run_time: pydantic.NonNegativeFloat = pydantic.Field(
0.0,
run_time: pydantic.PositiveFloat = pydantic.Field(
...,
title="Run Time",
description="Total electromagnetic evolution time in seconds. "
"Note: If simulation 'shutoff' is specified, "
"simulation will terminate early when shutoff condition met. "
"Must be set > 0 before running Simulation on our servers.",
"simulation will terminate early when shutoff condition met. ",
units=SECOND,
)

Expand Down Expand Up @@ -476,7 +475,7 @@ def validate_pre_upload(self) -> None:
"""Validate the fully initialized simulation is ok for upload to our servers."""
self._validate_size()
self._validate_monitor_size()
self._validate_run_time()
# self._validate_run_time()

def _validate_size(self) -> None:
"""Ensures the simulation is within size limits before simulation is uploaded."""
Expand Down

0 comments on commit 2074ed7

Please sign in to comment.