-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
inverse design with dispersive metallic antenna #124
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tylerflex! The new inverse design plugin seems very exciting!
Some comments about the notebook:
- Maybe @tomflexcompute could create a nice image for this example?
- I suggest to make this sentence more clear. "This uses the new autograd support in tidy3d >= 2.7.0 but the same differentiation support with respect to td.CustomPoleResidue is not supported in tidy3d's adjoint plugin.".
- Merge cells [2] and [3].
- It seems there are some comments in the cell [8] you need to remove. Like "# doesnt work" and "# medium_gold = td.material_library['SiN']['Horiba']"
- Cell numbers are missing after cell [11].
- It would be nice to introduce and give more details on the
invdes
plugin and the functionsmake_filter_and_project
, andget_kernel_size_px
after cell [11]. Or maybe include more details about the new inverse design architecture usingautograd
in the introduction. So, the existing Adjoint users could easily understand the differences between the new approach and the older one usingjax
. - Some typos:
- "the desity value" -> "the density value"
847f967
to
4355137
Compare
@e-g-melo I incoporated your suggestions, thanks! @tomflexcompute would you mind taking a look at this updated notebook? the results are much better now. |
Thanks @tylerflex . I remember leaving comments on both PRs but not sure why it's gone on this one. Anyway happy to read over the notebook again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tylerflex! It is a very interesting example!
4355137
to
dfee69d
Compare
Requires flexcompute/tidy3d#1761 for
CustomPoleResidue
support in autograd.Also the results aren't great yet.