Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/final styles fix #31

Merged
merged 7 commits into from
Dec 19, 2023
Merged

Feature/final styles fix #31

merged 7 commits into from
Dec 19, 2023

Conversation

sergio-usma
Copy link
Collaborator

🏁 Microverse's Final Capstone Project - [Frontend]

image

🔧 Frontend Refactoring and Styling Enhancements 🎨

In this series of commits, @sergio-usma has been hard at work refining the pages-layout for reservations, addCars, and reserve components in our project. Let's dive into the details of these improvements:

AddReservation Component Refactoring 🏷️ 🎨

  • Title Addition: 📑 Added a title to the AddReservation component for better clarity.
  • Styles Refactor: 💄 Conducted a thorough style refactor to enhance the overall aesthetic.
  • Logo Integration Across Components 🚗 🖼️
  • AddCar, AddReservation, ReservationList: :logo: Integrated our project logo into these key components for a consistent and polished look.
  • CarsCard Component: :logo: Further extended the logo inclusion to the CarsCard component, unifying the branding.
  • Mobile Responsiveness Improvements 📱 📐
  • CSS Class Refactor: 🎨 Enhanced the CSS classes for the Logo and addressed minor style issues in the mobile version for a seamless user experience.
  • BurguerMenu Component Rendering 🍔 💻
  • DeleteCar Page: ▶️ Successfully rendered the BurguerMenu component in the DeleteCar page, ensuring intuitive navigation.
    close [5pt] Styling and Responsiveness #7

These commits, orchestrated by @sergio-usma, not only refine the visual elements but also improve the overall structure and responsiveness of our frontend. The attention to detail is evident, making our application more user-friendly and visually appealing. Great job! 👏

🚀 Ready to elevate our user experience to new heights! 🚀

Copy link
Owner

@flemton flemton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

STATUS: APPROVED ✅ 🍾

Hi @sergio-usma
Your feature is complete! There is nothing else to say other than... it's time to merge it!
Congratulations! 🎇

approved

To highlight 🍾

Good PR description ✅
All linters passing ✅

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@flemton flemton merged commit 2321ffb into development Dec 19, 2023
3 checks passed
@flemton flemton deleted the feature/final_styles_fix branch December 19, 2023 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[5pt] Styling and Responsiveness
2 participants