Feature/add delete #27
Conversation
There was a problem hiding this comment.
Hi @SFarida
Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!
Highlight
🔆 Cars are deleted when delete button is pressed
🔆 the delete request was updated with the right endpoint
🔆 Solid and professional readme
Required Changes ♻️
- Check the inline comments under the review for sections to improve.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
N/A
Cheers and Happy coding!
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me @flemton in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
| <button | ||
| className="btn btn-dark px-5 text-white" | ||
| type="button" | ||
| onClick={() => navigate('/reserve')} | ||
| > |
There was a problem hiding this comment.
The reserve button should autofill the selected car when clicked from here and should only ask for start date, end date and city
It behaves correctly when the reserve model is clicked from the navigation.
There was a problem hiding this comment.
STATUS: APPROVED ✅ 🍾
Hi @SFarida
Your feature is complete! There is nothing else to say other than... it's time to merge it!
Congratulations! 🎇
To highlight 🍾
Fix reserve button in car details to include car ✅
Delete car from Nav now works ✅
Good PR description ✅
All linters passing ✅
Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
This PR contains the Delete component and some other fixes. Below are the details