Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request to merge Feature/add cars into development #22

Merged
merged 12 commits into from
Dec 17, 2023

Conversation

flemton
Copy link
Owner

@flemton flemton commented Dec 16, 2023

In this PR, I made the following changes

  • Created carsSlice for containing actions and reducers for cars
  • Add cars reducer to the global store
  • Add addCars request to add cars to the database through the Backend
  • Add getCars request to get cars present in the database
  • Add deleteCars request to delete cars from the database through the Backend
  • Add cars card component to house cars in cards
  • Add a Main component to contain all cars from cars card
  • Modified carsDetails component to show data from a selected car

This closes #8 , closes #10

@flemton flemton requested review from sergio-usma and SFarida and removed request for sergio-usma December 17, 2023 00:37
Copy link
Collaborator

@sergio-usma sergio-usma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

STATUS: APPROVED ✅ 🍾

Hi @flemton
Your feature is complete! There is nothing else to say other than... it's time to merge it!
Congratulations! 🎇

approved

To highlight 🍾

All linters are passing ✅
Good commit history ✅
Good PR description ✅

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@flemton flemton merged commit 0350cf9 into development Dec 17, 2023
3 checks passed
@flemton flemton deleted the feature/add-cars branch December 17, 2023 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[2pt] Delete item [3pt] Details Page
2 participants