Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unified Queue: add DB migration for existing pending activities #26413

Merged
merged 11 commits into from
Feb 19, 2025

Conversation

mna
Copy link
Member

@mna mna commented Feb 18, 2025

#25682

Checklist for submitter

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
    See Changes files for more information.
  • If database migrations are included, checked table schema to confirm autoupdate
  • For database migrations:
    • Checked schema for all modified table for columns that will auto-update timestamps during migration.
    • Confirmed that updating the timestamps is acceptable, and will not cause unwanted side effects.
  • Added/updated automated tests
  • Manual QA for all new/changed functionality

Copy link

codecov bot commented Feb 18, 2025

Codecov Report

Attention: Patch coverage is 87.85942% with 38 lines in your changes missing coverage. Please review.

Project coverage is 63.85%. Comparing base (bf41766) to head (98bedae).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...20250217093329_MigratePendingUpcomingActivities.go 87.85% 26 Missing and 12 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #26413      +/-   ##
==========================================
+ Coverage   63.79%   63.85%   +0.05%     
==========================================
  Files        1656     1657       +1     
  Lines      158749   159062     +313     
  Branches     4057     4093      +36     
==========================================
+ Hits       101277   101568     +291     
- Misses      49544    49557      +13     
- Partials     7928     7937       +9     
Flag Coverage Δ
backend 64.68% <87.85%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mna mna marked this pull request as ready for review February 18, 2025 15:48
@mna mna requested a review from a team as a code owner February 18, 2025 15:48
@getvictor getvictor self-requested a review February 18, 2025 22:24
Copy link
Member

@getvictor getvictor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

// macOS hosts will have their enrollment information inserted as well in the
// nano tables. It returns the host IDs of each platform, and the map of IDs to
// host UUIDs.
func insertHosts(t *testing.T, db *sqlx.DB, numMacOS, numWin, numLinux int) (macIDs, winIDs, linuxIDs []uint, idsToUUIDs map[uint]string) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mna mna merged commit 6049b39 into main Feb 19, 2025
32 checks passed
@mna mna deleted the mna-25682-uniq-data-migration branch February 19, 2025 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants