-
Notifications
You must be signed in to change notification settings - Fork 483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unified Queue: add DB migration for existing pending activities #26413
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #26413 +/- ##
==========================================
+ Coverage 63.79% 63.85% +0.05%
==========================================
Files 1656 1657 +1
Lines 158749 159062 +313
Branches 4057 4093 +36
==========================================
+ Hits 101277 101568 +291
- Misses 49544 49557 +13
- Partials 7928 7937 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
// macOS hosts will have their enrollment information inserted as well in the | ||
// nano tables. It returns the host IDs of each platform, and the map of IDs to | ||
// host UUIDs. | ||
func insertHosts(t *testing.T, db *sqlx.DB, numMacOS, numWin, numLinux int) (macIDs, winIDs, linuxIDs []uint, idsToUUIDs map[uint]string) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
#25682
Checklist for submitter
changes/
,orbit/changes/
oree/fleetd-chrome/changes
.See Changes files for more information.