Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[API design] Fleet-maintained apps for Windows #26381

Open
wants to merge 6 commits into
base: docs-v4.66.0
Choose a base branch
from

Conversation

noahtalerman
Copy link
Member

@noahtalerman noahtalerman commented Feb 17, 2025

API changes for the following user story:

Notes:

  • software_added will inform the UI that we want to disabled the "+ Add" button (Figma here):

Screenshot 2025-02-17 at 1 15 57 PM

Screenshot 2025-02-17 at 1 14 23 PM

Copy link

codecov bot commented Feb 17, 2025

Codecov Report

Attention: Patch coverage is 76.74353% with 827 lines in your changes missing coverage. Please review.

Please upload report for BASE (docs-v4.66.0@87597fc). Learn more about missing BASE report.

Files with missing lines Patch % Lines
server/mdm/android/service/endpoint_utils.go 0.00% 126 Missing ⚠️
server/datastore/mysql/activities.go 84.02% 59 Missing and 29 partials ⚠️
...r/mdm/android/mysql/testing_utils/testing_utils.go 58.73% 67 Missing and 18 partials ⚠️
cmd/fleet/serve.go 0.00% 72 Missing ⚠️
...ervice/middleware/endpoint_utils/endpoint_utils.go 72.19% 42 Missing and 15 partials ⚠️
server/mdm/android/service/service.go 0.00% 48 Missing ⚠️
server/datastore/mysql/software_installers.go 92.23% 27 Missing and 15 partials ⚠️
server/datastore/mysql/scripts.go 89.45% 22 Missing and 13 partials ⚠️
cmd/fleet/prepare.go 0.00% 33 Missing ⚠️
server/mdm/android/service/handler.go 0.00% 28 Missing ⚠️
... and 44 more
Additional details and impacted files
@@               Coverage Diff               @@
##             docs-v4.66.0   #26381   +/-   ##
===============================================
  Coverage                ?   63.79%           
===============================================
  Files                   ?     1653           
  Lines                   ?   158729           
  Branches                ?     4144           
===============================================
  Hits                    ?   101269           
  Misses                  ?    49531           
  Partials                ?     7929           
Flag Coverage Δ
backend 64.63% <76.73%> (?)
frontend 53.59% <77.77%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@noahtalerman noahtalerman marked this pull request as ready for review February 17, 2025 18:13
},
{
"id": 3,
"name": "Box Drive",
"version": "2.39.179",
"platform": "darwin"
"platform": "darwin",
"software_title_id": 1
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dev note

If the team already has the software added (as a Fleet-maintained app, App Store (app), or custom package), this is the software title ID for that software.

If the team doesn't have the software added, software_title_id is omitted.

@@ -9565,6 +9567,7 @@ Returns information about the specified Fleet-maintained app.
"platform": "darwin",
"install_script": "#!/bin/sh\ninstaller -pkg \"$INSTALLER_PATH\" -target /",
"uninstall_script": "#!/bin/sh\npkg_ids=$PACKAGE_ID\nfor pkg_id in '${pkg_ids[@]}'...",
"software_title_id": 3
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dev note

If the team already has the software added (as a Fleet-maintained app, App Store (app), or custom package), this is the software title ID for that software.

If the team doesn't have the software added, software_title_id is omitted.

@noahtalerman
Copy link
Member Author

FYI failing website test is unrelated to these changes:

Screenshot 2025-02-19 at 9 10 23 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants