Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring common mysql #26367

Merged
merged 70 commits into from
Feb 18, 2025
Merged

Refactoring common mysql #26367

merged 70 commits into from
Feb 18, 2025

Conversation

getvictor
Copy link
Member

@getvictor getvictor commented Feb 14, 2025

For #26218

Refactoring android/mysql/testing_utils.go to remove duplication with main mysql package.
No functional changes.

Checklist for submitter

  • Manual QA for all new/changed functionality

@getvictor getvictor force-pushed the victor/26218-refactoring-mysql branch from 6cdef58 to 6b28749 Compare February 15, 2025 21:41
@getvictor getvictor marked this pull request as ready for review February 17, 2025 13:22
@getvictor getvictor requested a review from a team as a code owner February 17, 2025 13:22
mna
mna previously approved these changes Feb 17, 2025
gillespi314
gillespi314 previously approved these changes Feb 17, 2025
Base automatically changed from victor/26218-refactoring to main February 18, 2025 17:09
@getvictor getvictor dismissed stale reviews from gillespi314 and mna February 18, 2025 17:09

The base branch was changed.

…ing-mysql

# Conflicts:
#	server/mdm/android/mysql/enterprises.go
#	server/mdm/android/mysql/enterprises_test.go
@getvictor getvictor merged commit 5ee9c0c into main Feb 18, 2025
35 checks passed
@getvictor getvictor deleted the victor/26218-refactoring-mysql branch February 18, 2025 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants