Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fleet-maintained apps: scripts are updated for you #26352

Merged
merged 3 commits into from
Feb 14, 2025

Conversation

noahtalerman
Copy link
Member

No description provided.

@noahtalerman
Copy link
Member Author

noahtalerman commented Feb 14, 2025

When scripts are fixed, after upgrading Fleet, they are automatically updated for you unless you edited any of the scripts.

@jahzielv this is true if you edit any of the scripts (install, post-install, uninstall) right? Meaning if Fleet fixes just the install script and you edited just the post-install script, Fleet won't edit your install script.

Also, this is true if you edit the script after you add the app right? Meaning you add an app without editing any scripts. Later you edit the install script. Fleet won't edit any of your scripts.

@jahzielv
Copy link
Contributor

this is true if you edit any of the scripts (install, post-install, uninstall) right? Meaning if Fleet fixes just the install script and you edited just the post-install script, Fleet won't edit your install script.

@noahtalerman it's true just for the scripts we generate, so just for the install and uninstall scripts. Postinstall scripts are completely custom so we don't edit those.

Also, this is true if you edit the script after you add the app right? Meaning you add an app without editing any scripts. Later you edit the install script. Fleet won't edit any of your scripts.

yep!

@noahtalerman
Copy link
Member Author

@noahtalerman: this is true if you edit any of the scripts (install, post-install, uninstall) right? Meaning if Fleet fixes just the install script and you edited just the post-install script, Fleet won't edit your install script.

@jahzielv: it's true just for the scripts we generate, so just for the install and uninstall scripts. Postinstall scripts are completely custom so we don't edit those.

Ah, right. Whoops I meant install/uninstall scripts.

@jahzielv so if Fleet fixes just the install script for App Z and you edited only the uninstall script for App Z, Fleet won't edit your install script for you, right? (and vice versa)

@noahtalerman noahtalerman merged commit 7477da3 into main Feb 14, 2025
5 checks passed
@noahtalerman noahtalerman deleted the noahtalerman-patch-21 branch February 14, 2025 20:27
@jahzielv
Copy link
Contributor

@jahzielv so if Fleet fixes just the install script for App Z and you edited only the uninstall script for App Z, Fleet won't edit your install script for you, right? (and vice versa)

yep, that sounds right to me!

iansltx added a commit that referenced this pull request Feb 17, 2025
iansltx added a commit that referenced this pull request Feb 17, 2025
…26400)

This reverts commit 7477da3.

See [this
comment](#25734 (comment))
for background. tl;dr: we _don't_, and _won't for now_, push script
updates down to installers when the scripts are updated on the FMA side.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants