Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gitops app config fields, API access, activities, tests #26282

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

jacobshandling
Copy link
Contributor

@jacobshandling jacobshandling commented Feb 12, 2025

For #26230

  • Add gitops settings to app config
  • GET and PATCH endpoint functionality to retrieve and modify these settings
  • generate activities for enabling and disabling GitOps mode
  • Premium only
  • Update tests
Screenshot 2025-02-17 at 9 22 13 AM Screenshot 2025-02-17 at 9 24 33 AM

Checklist for submitter

  • Added/updated automated tests
  • A detailed QA plan exists on the associated ticket (if it isn't there, work with the product group's QA engineer to add it)
  • Manual QA for all new/changed functionality

Copy link

codecov bot commented Feb 15, 2025

Codecov Report

Attention: Patch coverage is 86.36364% with 3 lines in your changes missing coverage. Please review.

Project coverage is 63.85%. Comparing base (403deb1) to head (b410347).
Report is 23 commits behind head on main.

Files with missing lines Patch % Lines
server/service/appconfig.go 86.36% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #26282      +/-   ##
==========================================
+ Coverage   63.72%   63.85%   +0.13%     
==========================================
  Files        1655     1656       +1     
  Lines      158544   159054     +510     
  Branches     4144     4125      -19     
==========================================
+ Hits       101032   101566     +534     
+ Misses      49587    49549      -38     
- Partials     7925     7939      +14     
Flag Coverage Δ
backend 64.69% <86.36%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jacobshandling jacobshandling marked this pull request as ready for review February 17, 2025 17:24
@jacobshandling jacobshandling requested review from rachaelshaw and a team as code owners February 17, 2025 17:24
@jacobshandling jacobshandling changed the title 25478 backend Add gitops app config fields, API access, activities, tests Feb 17, 2025
rachaelshaw
rachaelshaw previously approved these changes Feb 19, 2025
s.Do("PATCH", "/api/latest/fleet/config", json.RawMessage(`{
"gitops": { "gitops_mode_enabled": true, "repository_url": "a.b.cc" }
}`), http.StatusOK)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should just add a quick s.lastActivityOfTypeMatches to make sure the activity shows up when you enable gitops ui mode

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants