Exempt bootstrap package uploads from server-side request timeout #25536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #25536 +/- ##
==========================================
- Coverage 63.59% 63.59% -0.01%
==========================================
Files 1619 1619
Lines 155002 155003 +1
Branches 3985 3985
==========================================
- Hits 98572 98568 -4
- Misses 48659 48664 +5
Partials 7771 7771
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
getvictor
previously approved these changes
Jan 17, 2025
package.json
Outdated
| @@ -3,7 +3,7 @@ | |||
| "version": "0.99.99", | |||
| "description": "The premier osquery fleet manager.", | |||
| "engines": { | |||
| "node": "20.11.1", | |||
| "node": "20.18.1", | |||
There was a problem hiding this comment.
Is this change needed for this big fix?
| var zeroTime time.Time | ||
| rc := http.NewResponseController(rw) | ||
| // For large software installers, the server time needs time to read the full | ||
| // For large software installers and bootstrap packages, the server time needs time to read the full | ||
| // request body so we use the zero value to remove the deadline and override the | ||
| // default read timeout. | ||
| // TODO: Is this really how we want to handle this? Or would an arbitrarily long |
There was a problem hiding this comment.
Yes, a long timeout would be better. Otherwise, a bug in our agent with software/package download could DDOS our server.
There was a problem hiding this comment.
This covers a timeout long enough to upload a 2+GB installer over a slowish connection, so basically any timeout long enough to support that use case will be long enough to afford a DoS scenario unfortunately.
52f21bc to
a2e3cd5
Compare
getvictor
approved these changes
Jan 17, 2025
iansltx
added a commit
that referenced
this pull request
Jan 17, 2025
…5536) For #25533 - [x] Changes file added for user-visible changes in `changes/`, `orbit/changes/` or `ee/fleetd-chrome/changes`. See [Changes files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/Committing-Changes.md#changes-files) for more information. - [x] A detailed QA plan exists on the associated ticket (if it isn't there, work with the product group's QA engineer to add it) - [x] Manual QA for all new/changed functionality
lukeheath
pushed a commit
that referenced
this pull request
Jan 17, 2025
…5536) For #25533 - [x] Changes file added for user-visible changes in `changes/`, `orbit/changes/` or `ee/fleetd-chrome/changes`. See [Changes files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/Committing-Changes.md#changes-files) for more information. - [x] A detailed QA plan exists on the associated ticket (if it isn't there, work with the product group's QA engineer to add it) - [x] Manual QA for all new/changed functionality
lukeheath
pushed a commit
that referenced
this pull request
Jan 17, 2025
…5536) For #25533 - [x] Changes file added for user-visible changes in `changes/`, `orbit/changes/` or `ee/fleetd-chrome/changes`. See [Changes files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/Committing-Changes.md#changes-files) for more information. - [x] A detailed QA plan exists on the associated ticket (if it isn't there, work with the product group's QA engineer to add it) - [x] Manual QA for all new/changed functionality
lukeheath
pushed a commit
that referenced
this pull request
Jan 17, 2025
…5536) For #25533 - [x] Changes file added for user-visible changes in `changes/`, `orbit/changes/` or `ee/fleetd-chrome/changes`. See [Changes files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/Committing-Changes.md#changes-files) for more information. - [x] A detailed QA plan exists on the associated ticket (if it isn't there, work with the product group's QA engineer to add it) - [x] Manual QA for all new/changed functionality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #25533
changes/,orbit/changes/oree/fleetd-chrome/changes.See Changes files for more information.