-
Notifications
You must be signed in to change notification settings - Fork 483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes issue verifying Windows CSP profiles that contain ADMX policies. #25528
Merged
Merged
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
7ab3470
Refactoring VerifyHostMDMProfiles
getvictor 9e9972c
Fixes issue verifying Windows CSP profiles that contain ADMX policies.
getvictor 7186397
Renamed policies to profiles in profile_verifier.go
getvictor 3256973
Merge branch 'victor/24790-refactor' into victor/24790-admx
getvictor 7b390b7
Merge remote-tracking branch 'origin/main' into victor/24790-admx
getvictor 118ad0e
Improving ADMX XML parsing.
getvictor 966a8c2
Removed dead code.
getvictor File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Improving ADMX XML parsing.
- Loading branch information
commit 118ad0e7e078cb2fd36802b016e17cf13f5d2a60
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Won't
unescaped
already include the<admx/>
tags? Is it intentional to wrap in those<admx/>
again here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, unescaped looks like:
<enabled/><data id="Item" value="foo"/>
I don't know how to unmarshal it without adding a root XML element.
<admx>
is just a random throw-away name. It could be<bozo>