Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CODEOWNERS: reference docs #24704

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Update CODEOWNERS: reference docs #24704

merged 1 commit into from
Dec 12, 2024

Conversation

noahtalerman
Copy link
Member

Remove @noahtalerman so there's always one reviewer (@rachaelshaw)

I think I was added as backup when Rachael was out last week. I think in the future, let's do a full swap: remove @rachaelshaw and add @noahtalerman. That way we always have one reviewer. It's clear who's responsible for helping get the PR merged.

Remove @noahtalerman so there's always one reviewer (@rachaelshaw)

I think I was added as backup when Rachael was out last week. I think in the future, let's do a full swap: remove @rachaelshaw and add @noahtalerman. That way we always have one reviewer. It's clear who's responsible for helping get the PR merged.
@noahtalerman
Copy link
Member Author

I think in the future, let's do a full swap: remove @rachaelshaw and add @noahtalerman. That way we always have one reviewer. It's clear who's responsible for helping get the PR merged.

FYI @lukeheath let me know if you disagree. It looks like you were the one that added me last week: 941713d

Copy link
Member

@lukeheath lukeheath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, will do.

@lukeheath lukeheath merged commit 1db0c92 into main Dec 12, 2024
3 checks passed
@lukeheath lukeheath deleted the noahtalerman-patch-13 branch December 12, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants