Delete Fleet Desktop auth token when we detect a migrated host #23658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that "My device" correctly shows the current host immediately after migration, rather than the old host (Orbit is already reporting on the current host correctly due to swapped node keys)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #23658 +/- ##
==========================================
- Coverage 63.14% 63.14% -0.01%
==========================================
Files 1557 1557
Lines 147559 147562 +3
Branches 3686 3686
==========================================
+ Hits 93172 93173 +1
- Misses 47020 47022 +2
Partials 7367 7367
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mostlikelee
pushed a commit
that referenced
this pull request
Nov 10, 2024
#23164 This ensures that "My device" correctly shows the current host immediately after migration, rather than the old host (Orbit is already reporting on the current host correctly due to swapped node keys) # Checklist for submitter If some of the following don't apply, delete the relevant line. <!-- Note that API documentation changes are now addressed by the product design team. --> - [x] Changes file added for user-visible changes in `changes/`, `orbit/changes/` or `ee/fleetd-chrome/changes`. See [Changes files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/Committing-Changes.md#changes-files) for more information. - [x] Manual QA for all new/changed functionality - For Orbit and Fleet Desktop changes: - [x] Orbit runs on macOS, Linux and Windows. Check if the orbit feature/bugfix should only apply to one platform (`runtime.GOOS`). QA'd on macOS as there's a runtime guard on this code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#23164
This ensures that "My device" correctly shows the current host immediately after migration, rather than the old host (Orbit is already reporting on the current host correctly due to swapped node keys)
Checklist for submitter
If some of the following don't apply, delete the relevant line.
changes/,orbit/changes/oree/fleetd-chrome/changes.See Changes files for more information.
runtime.GOOS).QA'd on macOS as there's a runtime guard on this code.