Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick: Ensure edited scripts provided from the client with newline switches and no other changes get converted to "\n" (#22196) #22202

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

iansltx
Copy link
Member

@iansltx iansltx commented Sep 18, 2024

Merged to main in #22199.

git checkout minor-fleet-v4.57.0
git checkout -b 22196-cherry-pick
git cherry-pick ea2a9787338f780f7deb744c029c50d29dd6829d
git push -u origin 22196-cherry-pick

…and no other changes get converted to "\n" (#22196) (#22199)

# Checklist for submitter

- [x] Manual QA for all new/changed functionality
@iansltx iansltx merged commit 7d36b1b into minor-fleet-v4.57.0 Sep 18, 2024
12 checks passed
@iansltx iansltx deleted the 22196-cherry-pick branch September 18, 2024 15:09
Copy link

codecov bot commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Please upload report for BASE (minor-fleet-v4.57.0@0b5b129). Learn more about missing BASE report.

Files with missing lines Patch % Lines
ee/server/service/software_installers.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                   @@
##             minor-fleet-v4.57.0   #22202   +/-   ##
======================================================
  Coverage                       ?   65.23%           
======================================================
  Files                          ?     1493           
  Lines                          ?   116968           
  Branches                       ?     3462           
======================================================
  Hits                           ?    76303           
  Misses                         ?    33551           
  Partials                       ?     7114           
Flag Coverage Δ
backend 66.51% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants