For R.C. - Add installer edit side effects to batch installer update (via GitOps) #22191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#22100) #21612 # Checklist for submitter - [x] Changes file added for user-visible changes in `changes/`, `orbit/changes/` or `ee/fleetd-chrome/changes`. See [Changes files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/Committing-Changes.md#changes-files) for more information. - [x] Input data is properly validated, `SELECT *` is avoided, SQL injection is prevented (using placeholders for values in statements) - [x] Added/updated tests --------- Co-authored-by: RachelElysia <rachel@fleetdm.com> Co-authored-by: Luke Heath <luke@fleetdm.com> Co-authored-by: Jacob Shandling <jacob@fleetdm.com> Co-authored-by: Victor Lyuboslavsky <victor.lyuboslavsky@gmail.com>
iansltx
approved these changes
Sep 17, 2024
There was a problem hiding this comment.
Approving with the caveat that this will be QA'd in the AM based on the test plan listed in #21612. We have solid automated test coverage here, and it largely uses the same code path as the manually-QA'd main feature for the new bits.
 |
| Ran | Status | Preview | Started | Run time | Est. dev time saved |
|---|---|---|---|---|---|
| 64 workflows | Done (Details) | Visit preview | Sep 18, 2024 at 12:15 PM (UTC) | 11 minutes | ~23 hrs |
| 174 workflows | Done (Details) | Visit preview | Sep 18, 2024 at 12:18 PM (UTC) | 18 minutes | ~56.17 hrs |
Latest run
✅ 167 passed
Preexisting bugs
If you are aware of any of these bugs, you can set their priority to low and prevent them from causing a run failure.
View all blocking bugs
. . . . . . . .
Re-run your E2E tests
This was referenced Oct 4, 2024
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
This PR is already merged in
main, see #22100 This is against the release branch so it can be included in 4.57.0