Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes to policy software installations #22148

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

lucasmrod
Copy link
Member

PR for the three fixes described in #22104.

  • Added/updated tests
  • Manual QA for all new/changed functionality

Copy link

codecov bot commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 65.33%. Comparing base (ff01a87) to head (9a52220).
Report is 16 commits behind head on main.

Files with missing lines Patch % Lines
server/service/client.go 60.00% 4 Missing ⚠️
server/service/software_installers.go 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #22148      +/-   ##
==========================================
- Coverage   65.34%   65.33%   -0.01%     
==========================================
  Files        1493     1493              
  Lines      116651   116697      +46     
  Branches     3448     3448              
==========================================
+ Hits        76230    76249      +19     
- Misses      33306    33331      +25     
- Partials     7115     7117       +2     
Flag Coverage Δ
backend 66.66% <80.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@getvictor getvictor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lucasmrod lucasmrod merged commit 2d05f24 into main Sep 17, 2024
26 checks passed
@lucasmrod lucasmrod deleted the 22104-minor-fixes-to-policy-automations-install branch September 17, 2024 16:30
lucasmrod added a commit that referenced this pull request Sep 17, 2024
PR for the three fixes described in #22104.

- [X] Added/updated tests
- [X] Manual QA for all new/changed functionality
lucasmrod added a commit that referenced this pull request Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants