Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add software installer extension column to database #22017

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

iansltx
Copy link
Member

@iansltx iansltx commented Sep 11, 2024

#22044

This is distinct from the filename extension due to being based on package introspection.

Checklist for submitter

  • Input data is properly validated, SELECT * is avoided, SQL injection is prevented (using placeholders for values in statements)
  • Added/updated tests
  • If database migrations are included, checked table schema to confirm autoupdate
  • For database migrations:
    • Checked schema for all modified table for columns that will auto-update timestamps during migration.
    • Confirmed that updating the timestamps is acceptable, and will not cause unwanted side effects.
    • Ensured the correct collation is explicitly set for character columns (COLLATE utf8mb4_unicode_ci).
  • Manual QA for all new/changed functionality

Re: testing, will test this as part of my PR for #20404. I've tested the migration changes.

@iansltx iansltx requested a review from a team as a code owner September 11, 2024 20:10
@iansltx iansltx force-pushed the software-installer-extension-column branch from ad4e7d7 to 5d0860a Compare September 11, 2024 20:24
@iansltx iansltx force-pushed the software-installer-extension-column branch from 5d0860a to 4398585 Compare September 11, 2024 20:25
Copy link

codecov bot commented Sep 11, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 2 lines in your changes missing coverage. Please review.

Project coverage is 65.36%. Comparing base (eaa016b) to head (48b450c).

Files with missing lines Patch % Lines
...rations/tables/20240905200000_UninstallPackages.go 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #22017      +/-   ##
==========================================
+ Coverage   55.82%   65.36%   +9.53%     
==========================================
  Files        1494     1494              
  Lines      116474   116514      +40     
  Branches     3488     3488              
==========================================
+ Hits        65025    76154   +11129     
+ Misses      45203    33267   -11936     
- Partials     6246     7093     +847     
Flag Coverage Δ
backend 66.68% <85.71%> (+10.59%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from 20320-feat-uninstall-packages to main September 12, 2024 16:39
@iansltx iansltx force-pushed the software-installer-extension-column branch from 4398585 to b36d8e3 Compare September 12, 2024 17:52
@iansltx iansltx force-pushed the software-installer-extension-column branch from b36d8e3 to f4d9cf4 Compare September 12, 2024 18:27
@iansltx iansltx force-pushed the software-installer-extension-column branch from f4d9cf4 to c6eb6c6 Compare September 12, 2024 19:51
The extension column is distinct from the filename extension due to being based on package introspection.
@iansltx iansltx force-pushed the software-installer-extension-column branch from c6eb6c6 to 48b450c Compare September 12, 2024 20:31
Copy link
Member

@getvictor getvictor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iansltx iansltx merged commit 199dad2 into main Sep 12, 2024
23 of 25 checks passed
@iansltx iansltx deleted the software-installer-extension-column branch September 12, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants