-
Notifications
You must be signed in to change notification settings - Fork 483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add software installer extension column to database #22017
Conversation
ad4e7d7
to
5d0860a
Compare
5d0860a
to
4398585
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #22017 +/- ##
==========================================
+ Coverage 55.82% 65.36% +9.53%
==========================================
Files 1494 1494
Lines 116474 116514 +40
Branches 3488 3488
==========================================
+ Hits 65025 76154 +11129
+ Misses 45203 33267 -11936
- Partials 6246 7093 +847
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
4398585
to
b36d8e3
Compare
b36d8e3
to
f4d9cf4
Compare
f4d9cf4
to
c6eb6c6
Compare
The extension column is distinct from the filename extension due to being based on package introspection.
c6eb6c6
to
48b450c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
#22044
This is distinct from the filename extension due to being based on package introspection.
Checklist for submitter
SELECT *
is avoided, SQL injection is prevented (using placeholders for values in statements)COLLATE utf8mb4_unicode_ci
).Re: testing, will test this as part of my PR for #20404. I've tested the migration changes.