Remove engineering codeowners #21634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fleet-release
previously approved these changes
Aug 28, 2024
lucasmrod
reviewed
Aug 28, 2024
sharon-fdm
reviewed
Aug 28, 2024
| /server/worker/ @lucasmrod @getvictor @roperzh @gillespi314 @lukeheath | ||
| /server/vulnerabilities/ @lucasmrod @mostlikelee @getvictor @lukeheath | ||
| /server/cron/ @getvictor @lucasmrod @roperzh @mostlikelee @lukeheath | ||
| /ee/fleetd-chrome @lucasmrod @getvictor @RachelElysia |
There was a problem hiding this comment.
Folders without code owners will be open for all fleeties.
That's the intension?
There was a problem hiding this comment.
Yes, that's the intention, but I'm open to keeping some of these in codeowners if we think that's necessary. I'm hearing reports of this being a bottleneck for engineers.
There was a problem hiding this comment.
For example, the vulnerabilities directory that impacts the artifact build process.
There was a problem hiding this comment.
@lukeheath SGTM. Let me do a quick look to see if I have any such folders
There was a problem hiding this comment.
maybe the only missing is /ee/server for @\fleetdm/go
There was a problem hiding this comment.
@roperzh Good catch, added.
fleet-release
previously approved these changes
Aug 28, 2024
1accac2
fleet-release
approved these changes
Aug 28, 2024
georgekarrv
approved these changes
Aug 28, 2024
roperzh
pushed a commit
that referenced
this pull request
Aug 28, 2024
roperzh
added a commit
that referenced
this pull request
Aug 28, 2024
RachelElysia
pushed a commit
that referenced
this pull request
Sep 3, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.