Update CODEOWNERS and DRIs #20503
Merged
Update CODEOWNERS and DRIs #20503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- @lukeheath is interim DRI of API design while @rachaelshaw is out - @eashaw is interim DRI of product reference docs - @eashaw is also CODEOWNER of /docs b/c of doc generation markdown structure expertise and to unblock if Noah is slow to review
eashaw
reviewed
Jul 16, 2024
|
@noahtalerman We will need to update the website's custom configuration to enable auto-approvals for documentation PRs. Would you like me to add those changes to this PR? |
lukeheath
previously approved these changes
Jul 16, 2024
Co-authored-by: Eric <eashaw@sailsjs.com>
@eashaw yes please! Thanks for catching that. |
eashaw
previously approved these changes
Jul 17, 2024
mikermcneil
requested changes
Jul 17, 2024
CODEOWNERS
Outdated
| @@ -76,8 +76,8 @@ go.mod @fleetdm/go | |||
| # | |||
| # (see website/config/custom.js for DRIs of other paths not listed here) | |||
| ############################################################################################## | |||
| /docs @rachaelshaw | |||
| /docs/Using-Fleet/REST-API.md @rachaelshaw # « REST API reference documentation | |||
| /docs @rachaelshaw @eashaw @noahtalerman | |||
There was a problem hiding this comment.
When something needs to be reviewed, 1 person can hear about it and review it.
I.e. 1 DRI not 3
There was a problem hiding this comment.
@mikermcneil This is to provide backups while @rachaelshaw is out.
CODEOWNERS
Outdated
| /docs @rachaelshaw | ||
| /docs/Using-Fleet/REST-API.md @rachaelshaw # « REST API reference documentation | ||
| /docs @rachaelshaw @eashaw @noahtalerman | ||
| /docs/REST\ API/rest-api.md @rachaelshaw @lukeheath # « REST API reference documentation |
There was a problem hiding this comment.
@mikermcneil This is to provide backups while @rachaelshaw is out. Are you saying we should remove her and just list me?
fleet-release
approved these changes
Jul 17, 2024
mikermcneil
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs/b/c of doc generation markdown, structure expertise, and to unblock if Noah is slow to review