Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: don't remove user email from activity feed when user deleted #14975

Merged
merged 15 commits into from
Nov 9, 2023

Conversation

jahzielv
Copy link
Contributor

@jahzielv jahzielv commented Nov 6, 2023

Checklist for submitter

If some of the following don't apply, delete the relevant line.

  • Changes file added for user-visible changes in changes/ or orbit/changes/.
    See Changes files for more information.
  • Input data is properly validated, SELECT * is avoided, SQL injection is prevented (using placeholders for values in statements)
  • Added/updated tests
  • Manual QA for all new/changed functionality

@jahzielv jahzielv marked this pull request as ready for review November 7, 2023 17:36
@jahzielv jahzielv requested a review from a team as a code owner November 7, 2023 17:36
Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (182ce61) 58.98% compared to head (e385f10) 58.99%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14975   +/-   ##
=======================================
  Coverage   58.98%   58.99%           
=======================================
  Files         956      957    +1     
  Lines       80692    80727   +35     
  Branches     2251     2251           
=======================================
+ Hits        47600    47627   +27     
- Misses      29396    29402    +6     
- Partials     3696     3698    +2     
Flag Coverage Δ
backend 59.69% <78.94%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
server/datastore/mysql/activities.go 80.31% <100.00%> (+2.24%) ⬆️
server/fleet/activities.go 0.00% <ø> (ø)
.../tables/20231109115838_AddUserEmailToActivities.go 63.63% <63.63%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

getvictor
getvictor previously approved these changes Nov 9, 2023
Copy link
Member

@getvictor getvictor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. Please review my comments and make changes if needed.

server/datastore/mysql/activities.go Show resolved Hide resolved
server/fleet/activities.go Show resolved Hide resolved
server/datastore/mysql/activities.go Show resolved Hide resolved
server/datastore/mysql/activities.go Show resolved Hide resolved
Copy link
Member

@getvictor getvictor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jahzielv jahzielv merged commit 447b9e8 into main Nov 9, 2023
18 checks passed
@jahzielv jahzielv deleted the 12634-keep-user-email branch November 9, 2023 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants