-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: don't remove user email from activity feed when user deleted #14975
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #14975 +/- ##
=======================================
Coverage 58.98% 58.99%
=======================================
Files 956 957 +1
Lines 80692 80727 +35
Branches 2251 2251
=======================================
+ Hits 47600 47627 +27
- Misses 29396 29402 +6
- Partials 3696 3698 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good. Please review my comments and make changes if needed.
server/datastore/mysql/migrations/tables/20231107115838_AddUserEmailToActivities_test.go
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Checklist for submitter
If some of the following don't apply, delete the relevant line.
changes/
ororbit/changes/
.See Changes files for more information.
SELECT *
is avoided, SQL injection is prevented (using placeholders for values in statements)