Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: flaky tests fix + debug #14954

Closed
wants to merge 1 commit into from
Closed

wip: flaky tests fix + debug #14954

wants to merge 1 commit into from

Conversation

roperzh
Copy link
Contributor

@roperzh roperzh commented Nov 6, 2023

Checklist for submitter

If some of the following don't apply, delete the relevant line.

  • Changes file added for user-visible changes in changes/ or orbit/changes/.
    See Changes files for more information.
  • Documented any API changes (docs/REST API/rest-api.md or docs/Contributing/API-for-contributors.md)
  • Documented any permissions changes (docs/Using Fleet/manage-access.md)
  • Input data is properly validated, SELECT * is avoided, SQL injection is prevented (using placeholders for values in statements)
  • Added support on fleet's osquery simulator cmd/osquery-perf for new osquery data ingestion features.
  • Added/updated tests
  • Manual QA for all new/changed functionality
    • For Orbit and Fleet Desktop changes:
      • Manual QA must be performed in the three main OSs, macOS, Windows and Linux.
      • Auto-update manual QA, from released version of component to new version (see tools/tuf/test).

Copy link

codecov bot commented Nov 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (15dbc1b) 58.83% compared to head (eb5c13c) 58.87%.
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14954      +/-   ##
==========================================
+ Coverage   58.83%   58.87%   +0.03%     
==========================================
  Files         953      953              
  Lines       80236    80241       +5     
  Branches     2222     2222              
==========================================
+ Hits        47204    47238      +34     
+ Misses      29362    29330      -32     
- Partials     3670     3673       +3     
Flag Coverage Δ
backend 59.51% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@roperzh
Copy link
Contributor Author

roperzh commented Nov 9, 2023

@roperzh roperzh closed this Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant