Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest gon with notarytool until we find a better solution #14918

Merged
merged 13 commits into from
Nov 3, 2023

Conversation

georgekarrv
Copy link
Member

No description provided.

gillespi314
gillespi314 previously approved these changes Nov 3, 2023
Copy link
Contributor

@gillespi314 gillespi314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to also fix the related failed checks below, I'm happy to reapprove :)

@georgekarrv georgekarrv marked this pull request as draft November 3, 2023 17:45
@georgekarrv
Copy link
Member Author

Sorry gotta keep it in draft atm they changes the structs so it's broken builds in here 🗡️

@georgekarrv georgekarrv marked this pull request as ready for review November 3, 2023 20:25
roperzh
roperzh previously approved these changes Nov 3, 2023
Copy link
Contributor

@roperzh roperzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, seems to be working locally. One idea to fully test: trigger workflows/generate-desktop-targets.yml or workflows/build-orbit.yaml by modifying either in this PR

Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Attention: 19 lines in your changes are missing coverage. Please review.

Comparison is base (f9112e9) 58.83% compared to head (d5d29cb) 58.86%.

❗ Current head d5d29cb differs from pull request most recent head 755723a. Consider uploading reports for the commit 755723a to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14918      +/-   ##
==========================================
+ Coverage   58.83%   58.86%   +0.03%     
==========================================
  Files         953      953              
  Lines       80228    80236       +8     
  Branches     2222     2222              
==========================================
+ Hits        47200    47229      +29     
+ Misses      29357    29333      -24     
- Partials     3671     3674       +3     
Flag Coverage Δ
backend 59.50% <0.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
orbit/pkg/packaging/macos_notarize.go 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@georgekarrv georgekarrv merged commit 5177287 into main Nov 3, 2023
16 of 18 checks passed
@georgekarrv georgekarrv deleted the gkarr-gon-notarytool branch November 3, 2023 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants