-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to latest gon with notarytool until we find a better solution #14918
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want to also fix the related failed checks below, I'm happy to reapprove :)
Sorry gotta keep it in draft atm they changes the structs so it's broken builds in here 🗡️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, seems to be working locally. One idea to fully test: trigger workflows/generate-desktop-targets.yml
or workflows/build-orbit.yaml
by modifying either in this PR
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #14918 +/- ##
==========================================
+ Coverage 58.83% 58.86% +0.03%
==========================================
Files 953 953
Lines 80228 80236 +8
Branches 2222 2222
==========================================
+ Hits 47200 47229 +29
+ Misses 29357 29333 -24
- Partials 3671 3674 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
No description provided.