-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update heading position on why-fleet.md #14884
Conversation
I moved the "What's it for?" heading. I realized after checking the new content on the site that placing it between the new paragraphs disrupted the message. I also addressed some grammar and formatting issues. Removed some redundant words, and rephrased a couple of sentences to give a more personable tone.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's pick this up the next design review. (Added to agenda.)
docs/Get started/why-fleet.md
Outdated
@@ -31,42 +31,38 @@ Here are the platforms Fleet currently supports: | |||
- Linux-based IoT devices | |||
|
|||
## Lighter than air | |||
Fleet is lightweight and modular. You can use it for security without using it for MDM, and vice versa. You can turn off features you are not using. | |||
Fleet is lightweight and modular. You can use it for security without MDM and vice versa. You can turn off features you are not using. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
disagree with this line change. MDM is a capability, and this change makes it less clear
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, that makes sense.
I moved the "What's it for?" heading. After seeing it on the site (rather than Markdown) I feel that placing it between the new paragraphs disrupts the message.
I also addressed some grammar and formatting issues. Removed some redundant words and rephrased a couple of sentences to give a more personable tone.
Original
vs this PR