Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update heading position on why-fleet.md #14884

Merged
merged 13 commits into from
Nov 5, 2023
Merged

Conversation

mike-j-thomas
Copy link
Member

@mike-j-thomas mike-j-thomas commented Nov 2, 2023

I moved the "What's it for?" heading. After seeing it on the site (rather than Markdown) I feel that placing it between the new paragraphs disrupts the message.

I also addressed some grammar and formatting issues. Removed some redundant words and rephrased a couple of sentences to give a more personable tone.

Original

image

vs this PR

image

I moved the "What's it for?" heading.  I realized after checking the new content on the site that placing it between the new paragraphs disrupted the message.

I also addressed some grammar and formatting issues. Removed some redundant words, and rephrased a couple of sentences to give a more personable tone.
@mike-j-thomas mike-j-thomas temporarily deployed to Docker Hub November 2, 2023 03:40 — with GitHub Actions Inactive
@mike-j-thomas mike-j-thomas changed the title Update why-fleet.md Update heading position on why-fleet.md Nov 2, 2023
Copy link
Member

@mikermcneil mikermcneil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's pick this up the next design review. (Added to agenda.)

@@ -31,42 +31,38 @@ Here are the platforms Fleet currently supports:
- Linux-based IoT devices

## Lighter than air
Fleet is lightweight and modular. You can use it for security without using it for MDM, and vice versa. You can turn off features you are not using.
Fleet is lightweight and modular. You can use it for security without MDM and vice versa. You can turn off features you are not using.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

disagree with this line change. MDM is a capability, and this change makes it less clear

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, that makes sense.

@mike-j-thomas mike-j-thomas temporarily deployed to Docker Hub November 2, 2023 05:05 — with GitHub Actions Inactive
docs/Get started/why-fleet.md Outdated Show resolved Hide resolved
docs/Get started/why-fleet.md Outdated Show resolved Hide resolved
docs/Get started/why-fleet.md Outdated Show resolved Hide resolved
docs/Get started/why-fleet.md Outdated Show resolved Hide resolved
docs/Get started/why-fleet.md Outdated Show resolved Hide resolved
docs/Get started/why-fleet.md Outdated Show resolved Hide resolved
docs/Get started/why-fleet.md Outdated Show resolved Hide resolved
docs/Get started/why-fleet.md Outdated Show resolved Hide resolved
docs/Get started/why-fleet.md Outdated Show resolved Hide resolved
docs/Get started/why-fleet.md Outdated Show resolved Hide resolved
@mikermcneil mikermcneil merged commit 22af47a into main Nov 5, 2023
4 checks passed
@mikermcneil mikermcneil deleted the mike-j-thomas-why-fleet-patch branch November 5, 2023 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants