-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update mac settings components to os settings components #14570
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #14570 +/- ##
=======================================
Coverage 58.85% 58.85%
=======================================
Files 953 953
Lines 80241 80241
Branches 2222 2222
=======================================
Hits 47223 47223
Misses 29341 29341
Partials 3677 3677
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for following up with this chore!
@ghernandez345 if you want to fix conflicts, I can approve after! |
@ghernandez345 I converted to draft since this is no longer ready to merge. Feel free to update once the conflicts are resolved. |
@lukeheath no worries. @gillespi314 I've sorted the merge conflicts and its ready for a review again. |
update the mac settings components naming to be less specific to mac os