Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mac settings components to os settings components #14570

Merged
merged 2 commits into from
Nov 7, 2023

Conversation

ghernandez345
Copy link
Contributor

update the mac settings components naming to be less specific to mac os

  • Manual QA for all new/changed functionality

@ghernandez345 ghernandez345 requested a review from a team as a code owner October 16, 2023 15:01
@ghernandez345 ghernandez345 temporarily deployed to Docker Hub October 16, 2023 15:01 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (5391b68) 58.85% compared to head (02f5860) 58.85%.
Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14570   +/-   ##
=======================================
  Coverage   58.85%   58.85%           
=======================================
  Files         953      953           
  Lines       80241    80241           
  Branches     2222     2222           
=======================================
  Hits        47223    47223           
  Misses      29341    29341           
  Partials     3677     3677           
Flag Coverage Δ
frontend 52.13% <70.58%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...sTable/OSSettingStatusCell/OSSettingStatusCell.tsx 48.71% <100.00%> (ø)
...ngStatusCell/components/Tooltip/ActionRequired.tsx 11.11% <ø> (ø)
...ngStatusCell/components/Tooltip/TooltipContent.tsx 83.33% <ø> (ø)
...SSettingsModal/OSSettingsTable/OSSettingsTable.tsx 66.66% <100.00%> (ø)
...ngsModal/OSSettingsTable/OSSettingsTableConfig.tsx 11.90% <ø> (ø)
...es/hosts/details/cards/HostSummary/HostSummary.tsx 65.07% <ø> (ø)
...ummary/OSSettingsIndicator/OSSettingsIndicator.tsx 13.88% <66.66%> (ø)
...es/hosts/details/DeviceUserPage/DeviceUserPage.tsx 61.21% <60.00%> (ø)
.../hosts/details/OSSettingsModal/OSSettingsModal.tsx 28.57% <50.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

gillespi314
gillespi314 previously approved these changes Oct 19, 2023
Copy link
Contributor

@gillespi314 gillespi314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for following up with this chore!

@RachelElysia
Copy link
Member

@ghernandez345 if you want to fix conflicts, I can approve after!

@lukeheath lukeheath marked this pull request as draft November 3, 2023 19:50
@lukeheath
Copy link
Member

@ghernandez345 I converted to draft since this is no longer ready to merge. Feel free to update once the conflicts are resolved.

@ghernandez345
Copy link
Contributor Author

@lukeheath no worries. @gillespi314 I've sorted the merge conflicts and its ready for a review again.

@ghernandez345 ghernandez345 merged commit eacf9cb into main Nov 7, 2023
13 checks passed
@ghernandez345 ghernandez345 deleted the chore-ui-update-mac-settings-components branch November 7, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants