Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle RPM upgrade in %postun script #14379

Merged
merged 3 commits into from
Oct 27, 2023
Merged

Handle RPM upgrade in %postun script #14379

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5c88732
Add a conditional check in the %postun script to prevent file deletio…
edwardsb Oct 9, 2023
4590f86
add changes file for orbit 14380
edwardsb Oct 9, 2023
916e2e5
🐛 fix(linux_shared.go): add condition to handle Debian package removal
edwardsb Oct 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions orbit/changes/14380-rpm-graceful-upgrade
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
* Add a conditional check in the %postun script to prevent file deletion during RPM upgrade. The check ensures that files and directories are only removed during a full uninstall ( equals 0), safeguarding necessary files from unintended deletion during an upgrade.
6 changes: 5 additions & 1 deletion orbit/pkg/packaging/linux_shared.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -364,7 +364,11 @@ pkill fleet-desktop || true
func writePostRemove(opt Options, path string) error {
if err := ioutil.WriteFile(path, []byte(`#!/bin/sh

rm -rf /var/lib/orbit /var/log/orbit /usr/local/bin/orbit /etc/default/orbit /usr/lib/systemd/system/orbit.service /opt/orbit
# For RPM during uninstall, $1 is 0
# For Debian during remove, $1 is "remove"
if [ "$1" = 0 ] || [ "$1" = "remove" ]; then
rm -rf /var/lib/orbit /var/log/orbit /usr/local/bin/orbit /etc/default/orbit /usr/lib/systemd/system/orbit.service /opt/orbit
fi
`), constant.DefaultFileMode); err != nil {
return fmt.Errorf("write file: %w", err)
}
Expand Down