Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Puppet module might unintentionally remove profiles from a team if one or more /preassign call fails but the /match succeeds #16954

Closed
roperzh opened this issue Feb 19, 2024 · 7 comments
Closed

Puppet module might unintentionally remove profiles from a team if one or more /preassign call fails but the /match succeeds #16954

roperzh opened this issue Feb 19, 2024 · 7 comments
Assignees
@roperzh
Labels
~backend Backend-related issue. bug Something isn't working as documented bug-mac-profiles Defect in Mac MDM profiles. bug-puppet Defect in Puppet modue. customer-eponym #g-mdm MDM product group :incoming New issue in triage process. :release Ready to write code. Scheduled in a release. See "Making changes" in handbook. ~released bug This bug was found in a stable release.
Milestone
4.47.0

Comments

@roperzh
Copy link
Contributor

roperzh commented Feb 19, 2024

Fleet version: 4.44.1, Puppet module: 0.2.3

💥  Actual behavior

Some profiles were removed from a team.

🧑‍💻  Steps to reproduce

  1. Assign 3 profiles to a team
  2. Make a Puppet run succeed
  3. Make another Puppet run, but this time force a failure in one or more preassign API calls
  4. Observe how the profiles are removed

🕯️ More info (optional)

The inner workings of the Puppet module are described here

image
@roperzh roperzh added bug Something isn't working as documented ~backend Backend-related issue. customer-eponym bug-mac-profiles Defect in Mac MDM profiles. bug-puppet Defect in Puppet modue. :incoming New issue in triage process. labels Feb 19, 2024
@lukeheath lukeheath added the ~released bug This bug was found in a stable release. label Feb 19, 2024
@georgekarrv georgekarrv added the :release Ready to write code. Scheduled in a release. See "Making changes" in handbook. label Feb 20, 2024
@sharon-fdm
Copy link
Collaborator

@georgekarrv, this was caught in the NO-TEAM-SEARCH query.
Add mdm label?

@roperzh roperzh added the #g-mdm MDM product group label Feb 20, 2024
@roperzh
Copy link
Contributor Author

roperzh commented Feb 20, 2024

@sharon-fdm yes, thanks and sorry for missing it!

@lukeheath lukeheath added this to the 4.46.0-tentative milestone Feb 21, 2024
@roperzh roperzh self-assigned this Feb 23, 2024
roperzh added a commit that referenced this issue Feb 26, 2024
@roperzh
puppet module: prevent running match call if a preassignment failed
3441c95 
for #16954
@roperzh roperzh mentioned this issue Feb 26, 2024
Merged
2 tasks
roperzh pushed a commit that referenced this issue Feb 28, 2024
puppet module: prevent running match call if a preassignment failed (#…
456bc3c 
…17175)

for #16954

# Checklist for submitter

If some of the following don't apply, delete the relevant line.

<!-- Note that API documentation changes are now addressed by the
product design team. -->

- [x] Added/updated tests
- [x] Manual QA for all new/changed functionality
@roperzh
Copy link
Contributor Author

roperzh commented Mar 1, 2024

thanks to @sabrinabuckets we found an issue with the current implementation, pulling from "Awaiting QA" until it's fixed

@roperzh roperzh mentioned this issue Mar 1, 2024
Merged
2 tasks
roperzh added a commit that referenced this issue Mar 1, 2024
@roperzh
string match on the resource report key instead of the keyval pair
27c151e 
for #16954, this fixes an issue found during testing
roperzh pushed a commit that referenced this issue Mar 1, 2024
string match on the resource report key instead of the keyval pair (#…
ea73b5a 
…17294)

for #16954, this fixes an issue found during testing

# Checklist for submitter

If some of the following don't apply, delete the relevant line.

- [x] Added/updated tests
- [x] Manual QA for all new/changed functionality
@roperzh
Copy link
Contributor Author

roperzh commented Mar 1, 2024

@sabrinabuckets a fix has been merged, moving this back to the QA column, sorry for the inconvenience! 🙏

@sabrinabuckets
Copy link
Contributor

@roperzh perfect! I will find a time for us to re-test!

@sabrinabuckets
Copy link
Contributor

Paired with Roberto to reproduce original issue and verify fix.

@mna mna mentioned this issue Mar 6, 2024
Closed
@georgekarrv georgekarrv added :demo and removed :demo labels Mar 8, 2024
@fleet-release
Copy link
Contributor

I couldn't think of a haiku this time. (See fleetdm.com logs for more information.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roperzh roperzh

Labels
~backend Backend-related issue. bug Something isn't working as documented bug-mac-profiles Defect in Mac MDM profiles. bug-puppet Defect in Puppet modue. customer-eponym #g-mdm MDM product group :incoming New issue in triage process. :release Ready to write code. Scheduled in a release. See "Making changes" in handbook. ~released bug This bug was found in a stable release.
Projects
None yet
Milestone
4.47.0
Development

No branches or pull requests
6 participants
@georgekarrv @lukeheath @roperzh @sabrinabuckets @fleet-release @sharon-fdm