Skip to content

Commit

Permalink
Fix auto-approval + CODEOWNER blockage (#18668)
Browse files Browse the repository at this point in the history
- Remove redundant callouts for Luke in issue templates
- Fix auto-approval + CODEOWNER blockage 
cc @lukeheath
  • Loading branch information
Sampfluger88 authored May 1, 2024
1 parent 065d8c9 commit 28742fc
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 8 deletions.
8 changes: 4 additions & 4 deletions CODEOWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -77,12 +77,12 @@ go.mod @fleetdm/go
/handbook/company/pricing-features-table.yml @noahtalerman # « Head of Product Design is current DRI for features table

##############################################################################################
# 🦿 Repo automation and change control settings
# 🌐 Repo automation and change control settings
##############################################################################################
# /CODEOWNERS @mikermcneil # Covered in DRIs

##############################################################################################
# 🦿 Handbook
# 🌐 Handbook
#
# (see website/config/custom.js for DRIs of other paths not listed here)
##############################################################################################
Expand All @@ -102,9 +102,9 @@ go.mod @fleetdm/go
/handbook/product-design @sampfluger88

##############################################################################################
# 🦿 GitHub issue templates
# 🌐 GitHub issue templates
##############################################################################################
/.github/ISSUE_TEMPLATE @mikermcneil @sampfluger88 @lukeheath # See https://github.com/fleetdm/fleet/pull/16203
#/.github/ISSUE_TEMPLATE @mikermcneil @sampfluger88 @lukeheath # Covered in custom.js See https://github.com/fleetdm/fleet/pull/18668

##############################################################################################
# 🌐 GitHub workflows
Expand Down
8 changes: 4 additions & 4 deletions website/config/custom.js
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ module.exports.custom = {


// 🌐 GitHub issue templates
//'.github/ISSUE_TEMPLATE': 'mikermcneil',// « Covered in CODEOWNERS (2023-08-10)
'.github/ISSUE_TEMPLATE': 'sampfluger88',

},

Expand Down Expand Up @@ -262,9 +262,9 @@ module.exports.custom = {

// GitHub issue templates
'.github/ISSUE_TEMPLATE': ['mikermcneil', 'lukeheath', 'sampfluger88'],
'.github/ISSUE_TEMPLATE/bug-report.md': ['xpkoala','noahtalerman', 'lukeheath'],
'.github/ISSUE_TEMPLATE/feature-request.md': ['xpkoala','noahtalerman', 'lukeheath'],
'.github/ISSUE_TEMPLATE/release-qa.md': ['xpkoala','lukeheath','noahtalerman', 'lukeheath'],
'.github/ISSUE_TEMPLATE/bug-report.md': ['xpkoala','noahtalerman'],
'.github/ISSUE_TEMPLATE/feature-request.md': ['xpkoala','noahtalerman'],
'.github/ISSUE_TEMPLATE/release-qa.md': ['xpkoala','noahtalerman'],
},

confidentialGithubRepoMaintainersByPath: {// fleetdm/confidential
Expand Down

0 comments on commit 28742fc

Please sign in to comment.