FOGL-8760 permissions optional support added in configuration Manager along with restrictions on configuration update API #1411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ashish-jabble <ashish@dianomic.com>
…KV pair Signed-off-by: ashish-jabble <ashish@dianomic.com>
Signed-off-by: ashish-jabble <ashish@dianomic.com>
… type Signed-off-by: ashish-jabble <ashish@dianomic.com>
Signed-off-by: ashish-jabble <ashish@dianomic.com>
Signed-off-by: ashish-jabble <ashish@dianomic.com>
…ged in user type is not given in the list of permission; also updated unit tests Signed-off-by: ashish-jabble <ashish@dianomic.com>
praveen-garg
reviewed
Jul 3, 2024
praveen-garg
reviewed
Jul 4, 2024
| if not request.user_is_admin: | ||
| if 'permission' in cat_info[item_name]: | ||
| if not (user_role_name in cat_info[item_name]['permission']): | ||
| raise Exception('Forbidden') |
There was a problem hiding this comment.
Better to add a know exception custom class, AccessDenied or PermissionDenied and handle that instead of string match
There was a problem hiding this comment.
yeah it was planned but this exception actually to be defined in user model but Not in configuration manager; due to avoid of circular dependency issue, I have kept it under general exception having message Forbidden to get the actual HTTP status code.
Signed-off-by: ashish-jabble <ashish@dianomic.com>
Signed-off-by: ashish-jabble <ashish@dianomic.com>
MarkRiddoch
approved these changes
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.