Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #34: Unify app framework with Android MVP implementation #35

Merged
merged 1 commit into from
Dec 28, 2024

Conversation

garotm
Copy link
Member

@garotm garotm commented Dec 28, 2024

  • Add Android MVP implementation
  • Update CI/CD workflows
  • Update documentation
  • Integrate build configurations

Tests

MacStudio-M1:RunOn garotconklin$ pwd
/Users/garotconklin/garotm/fleXRPL/RunOn
MacStudio-M1:RunOn garotconklin$ bash backend/scripts/format_and_lint.sh && bash android/scripts/setup.sh 
Running Black formatter...
All done! ✨ 🍰 ✨
22 files left unchanged.
Running isort import sorter...
Running flake8 linter...
Running pytest with coverage...
=============================================================================== test session starts ================================================================================
platform darwin -- Python 3.9.18, pytest-7.4.3, pluggy-1.5.0
rootdir: /Users/garotconklin/garotm/fleXRPL/RunOn/backend
configfile: pytest.ini
testpaths: tests
plugins: asyncio-0.23.8, cov-4.1.0, mock-3.12.0, anyio-3.7.1
asyncio: mode=strict
collected 9 items                                                                                                                                                                  

tests/test_basic.py .                                                                                                                                                        [ 11%]
tests/test_conftest.py .                                                                                                                                                     [ 22%]
tests/calendar_sync/test_calendar.py ..                                                                                                                                      [ 44%]
tests/config/test_environment.py ..                                                                                                                                          [ 66%]
tests/event_discovery/test_search.py ..                                                                                                                                      [ 88%]
tests/models/test_event.py .                                                                                                                                                 [100%]

---------- coverage: platform darwin, python 3.9.18-final-0 ----------
Name                                    Stmts   Miss  Cover   Missing
---------------------------------------------------------------------
config/__init__.py                          2      0   100%
config/environment.py                      12      0   100%
docs/__init__.py                            0      0   100%
functions/__init__.py                       0      0   100%
functions/calendar_sync/__init__.py         0      0   100%
functions/calendar_sync/calendar.py        13      0   100%
functions/event_discovery/__init__.py       0      0   100%
functions/event_discovery/search.py         7      0   100%
models/__init__.py                          2      0   100%
models/event.py                            12      0   100%
tests/__init__.py                           2      0   100%
tests/calendar_sync/__init__.py             0      0   100%
tests/calendar_sync/test_calendar.py       23      0   100%
tests/config/__init__.py                    0      0   100%
tests/config/test_environment.py           13      0   100%
tests/conftest.py                           6      0   100%
tests/event_discovery/__init__.py           0      0   100%
tests/event_discovery/test_search.py       16      0   100%
tests/models/__init__.py                    0      0   100%
tests/models/test_event.py                 10      0   100%
tests/test_basic.py                         3      0   100%
tests/test_conftest.py                      9      0   100%
---------------------------------------------------------------------
TOTAL                                     130      0   100%
Coverage XML written to file coverage.xml

Required test coverage of 80% reached. Total coverage: 100.00%

================================================================================ 9 passed in 0.21s =================================================================================
🚀 Setting up Android development environment...
📝 Checking Java version...
📦 Installing required tools...
✓ Gradle already installed
✓ Kotlin already installed
Using Java from: /Users/garotconklin/homebrew/Cellar/openjdk@17/17.0.13/libexec/openjdk.jdk/Contents/Home
📱 Setting up Android SDK...
✓ Android Command Line Tools already installed
Warning: Errors during XML parse:                                               
Warning: Additionally, the fallback loader failed to parse the XML.             
Warning: Errors during XML parse:                                               
Warning: Additionally, the fallback loader failed to parse the XML.             
[=======================================] 100% Computing updates...             
All SDK package licenses accepted.

Installing Android SDK components...            
Warning: Errors during XML parse:                                               
Warning: Additionally, the fallback loader failed to parse the XML.             
[=======================================] 100% Computing updates...             

Warning: Errors during XML parse:
Warning: Additionally, the fallback loader failed to parse the XML.
✓ Debug keystore already exists
🔧 Setting up Gradle wrapper...

BUILD SUCCESSFUL in 4s
1 actionable task: 1 up-to-date
🔑 Setting permissions...
🧹 Running formatting...
🧹 Running code formatting...
Running ktlint...

BUILD SUCCESSFUL in 1s
3 actionable tasks: 3 up-to-date
✅ Code formatting complete!
🏗️  Running initial build...

[Incubating] Problems report is available at: file:///Users/garotconklin/garotm/fleXRPL/RunOn/android/build/reports/problems/problems-report.html

Deprecated Gradle features were used in this build, making it incompatible with Gradle 9.0.

You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.

For more on this, please refer to https://docs.gradle.org/8.12/userguide/command_line_interface.html#sec:command_line_warnings in the Gradle documentation.

BUILD SUCCESSFUL in 2s
92 actionable tasks: 2 executed, 90 up-to-date
✅ Setup complete! You can now run:
cd android
./scripts/format_and_lint.sh
📁 Creating project structure...

- Add Android MVP implementation
- Update CI/CD workflows
- Update documentation
- Integrate build configurations
@garotm garotm requested a review from a team December 28, 2024 00:33
@garotm garotm self-assigned this Dec 28, 2024
@garotm garotm added the enhancement New feature or request label Dec 28, 2024
@garotm garotm added this to the MVP milestone Dec 28, 2024
@garotm
Copy link
Member Author

garotm commented Dec 28, 2024

@garotm garotm merged commit 0d5b451 into main Dec 28, 2024
5 checks passed
@garotm garotm deleted the issue-34-unify-framework branch December 29, 2024 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant