Provides workaround for nested scripts #128
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a solution to: #127
Regarding the solution:
I found that there was no easy way to sort this at the node level, as the problem is specifically that sibling nodes could, together after destroying a middle node become problematic.
I chose to restart a clean on fragments and documents if their representation
raw_text
was deemed to be problematic.Regarding defaults:
Due to some existing expectations on the specs, the proposed solution is not 100% retrocompatible, hence I introduced the new 'safer' method recursive_scrub_fragment (and document).
Regarding testing
I did integration testing to make sure that: we are modifying the behaviour as slightly as possible.
We solve the nested script validation issue.