Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provides workaround for nested scripts #128

Closed

Conversation

myxoh
Copy link

@myxoh myxoh commented Oct 10, 2017

This is a solution to: #127

Regarding the solution:
I found that there was no easy way to sort this at the node level, as the problem is specifically that sibling nodes could, together after destroying a middle node become problematic.
I chose to restart a clean on fragments and documents if their representation raw_text was deemed to be problematic.

Regarding defaults:
Due to some existing expectations on the specs, the proposed solution is not 100% retrocompatible, hence I introduced the new 'safer' method recursive_scrub_fragment (and document).

Regarding testing
I did integration testing to make sure that: we are modifying the behaviour as slightly as possible.
We solve the nested script validation issue.

@myxoh myxoh mentioned this pull request Oct 10, 2017
@flavorjones
Copy link
Owner

I'm looking at this now. Thanks for submitting.

@flavorjones
Copy link
Owner

Please see discussion at #127 which I'd like to understand before commenting on this approach.

@flavorjones
Copy link
Owner

Note that I've addressed example 1 in #127 with #132 which I feel is more obvious and more targetted.

I'll leave this open while we continue the conversation about examples 2 and 3 in #127.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants