FavIcon plugin fine-tuning #428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases, especially with shared hosts, there is already a favicon.ico file in the HTTP root directory. However, a development document at Googledocs describes that there should only be one icon per HTTP host/website. My observation over several weeks in the Google Searchconsole is that the crawler is irritated if either several favicon.ico files are present in the website (http host) or the crawler is fobbed off with 404. The effect is that no favicon file is displayed in the search results during indexing. A temporary redirection (http_response_code 307) when the plugin is active seems more elegant -> implemented here. When the plugin is active, the user agent and the crawler also receive a message (?v=2) that the HTTP host is equipped with new favicons. In addition, some FlatPress icons have been given a final polish. This is particularly noticeable on mobile devices and search engines, but also when creating a FlatPress link in social media. You can use https://realfavicongenerator.net/favicon_checker for testing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, especially with shared hosts, there is already a favicon.ico file in the HTTP root directory. However, a development document at Googledocs describes that there should only be one icon per HTTP host/website.
My observation over several weeks in the Google Searchconsole is that the crawler is irritated if either several favicon.ico files are present in the website (http host) or the crawler is fobbed off with 404.
The effect is that no favicon file is displayed in the search results during indexing.
A temporary redirection
http_response_code(307)when the plugin is active seems more elegant -> implemented here. When the plugin is active, the user agent and the crawler also receive a message (?v=2) that the HTTP host is equipped with new favicons.In addition, some FlatPress icons have been given a final polish. This is particularly noticeable on mobile devices and search engines, but also when creating a FlatPress link in social media.
You can use https://realfavicongenerator.net/favicon_checker for testing.