Fixes: There is no Cookie Prefix on this cookie #245
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes flatpressblog#155 Sets the secure attribute for FlatPress cookies
- A cookie that comes via an HTTP connection cannot have the "secure" flag and the "__secure-" attribute. - A cookie that comes via an HTTP connection must not have the "samesite" value "None", "Lax" or "Strict". - Cookies with the "secure" and "HTTPONLY" attribute are only permitted to be sent via HTTPS.
- A cookie that comes via an HTTP connection cannot have the "secure" flag and the "__secure-" attribute. - A cookie that comes via an HTTP connection must not have the "samesite" value "None", "Lax" or "Strict". - Cookies with the "secure" and "HTTPONLY" attribute are only permitted to be sent via HTTPS.
|
Worked into Branch issue371_httphttps - excellent work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #155
This prefix is the more relaxed in terms of the restrictions it applies but is still useful. You simply prefix your cookie and a compliant browser will enforce it:
Set-Cookie: __Secure-sess=123; path=/; SecureThe __secure prefix signals to the browser that the SecureAttribute is required.
In addition, the problem that you cannot log in to the admin area via a non-HTTPS connection has been fixed. Reported by @prbt2016 in #371. Many thanks also at this point. Also #375 was created as a suggestion.