Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix contributing install instruction #309

Merged
merged 1 commit into from
Feb 13, 2025
Merged

Conversation

sjvenditto
Copy link
Collaborator

Addresses issue #228

@sjvenditto sjvenditto requested a review from billbrod February 13, 2025 20:44
@sjvenditto sjvenditto changed the base branch from main to development February 13, 2025 20:46
@sjvenditto sjvenditto requested a review from gviejo February 13, 2025 20:47
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.34%. Comparing base (a510ef3) to head (17f40ce).
Report is 207 commits behind head on development.

Additional details and impacted files
@@               Coverage Diff               @@
##           development     #309      +/-   ##
===============================================
+ Coverage        96.13%   97.34%   +1.20%     
===============================================
  Files               34       35       +1     
  Lines             2642     2862     +220     
===============================================
+ Hits              2540     2786     +246     
+ Misses             102       76      -26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BalzaniEdoardo
Copy link
Collaborator

I love it, the number of reviewers is so random! anyone here wants to assign the review to Alex instead? 😂😂
...I know the policy originally required 2 approvals, but I'll relaxed it to one only.

First PR for @sjvenditto, more fun PRs to come! 🚀 🚀🚀

Copy link
Collaborator

@BalzaniEdoardo BalzaniEdoardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am a big fun of single quotations, but this time I will let this slide 😂

@BalzaniEdoardo BalzaniEdoardo merged commit cd22da9 into development Feb 13, 2025
14 checks passed
@BalzaniEdoardo BalzaniEdoardo deleted the fix_contributing branch February 13, 2025 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants