-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changelog: upgrade toolbox to latest version #1785
Merged
pothos
merged 1 commit into
flatcar:main
from
daMupfel:dont-remove-snapshot-on-gc-after-lease-expiration
Mar 26, 2024
Merged
changelog: upgrade toolbox to latest version #1785
pothos
merged 1 commit into
flatcar:main
from
daMupfel:dont-remove-snapshot-on-gc-after-lease-expiration
Mar 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daMupfel
force-pushed
the
dont-remove-snapshot-on-gc-after-lease-expiration
branch
2 times, most recently
from
March 22, 2024 14:55
2e2655d
to
2030e78
Compare
pothos
reviewed
Mar 25, 2024
changelog/bugfixes/2024-03-22-toolbox-prevent-snapshots-from-being-gced.md
Outdated
Show resolved
Hide resolved
pothos
approved these changes
Mar 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I made a minor suggestion for the release note wording
daMupfel
force-pushed
the
dont-remove-snapshot-on-gc-after-lease-expiration
branch
2 times, most recently
from
March 26, 2024 07:22
4772a5e
to
9dbdfb3
Compare
Hi pothos, Thanks for the review. I adapted according to your request :). Regards, David |
This version fixes that mounted snapshots with ctr are being gc'ed which breaks the toolbox.
daMupfel
force-pushed
the
dont-remove-snapshot-on-gc-after-lease-expiration
branch
from
March 26, 2024 07:26
9dbdfb3
to
e5179b2
Compare
pothos
added a commit
that referenced
this pull request
Mar 26, 2024
changelog: upgrade toolbox to latest version
pothos
added a commit
that referenced
this pull request
Mar 26, 2024
changelog: upgrade toolbox to latest version
pothos
added a commit
that referenced
this pull request
Mar 26, 2024
changelog: upgrade toolbox to latest version
pothos
added a commit
that referenced
this pull request
Mar 26, 2024
changelog: upgrade toolbox to latest version
Thanks, I've backported it to all channels |
Build action triggered: https://github.com/flatcar/scripts/actions/runs/8433019289 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This version fixes that mounted snapshots with ctr are being gc'ed which breaks the toolbox.
Upgrade toolbox
As requested on toolbox pr flatcar/toolbox#9.
changelog/
directory (user-facing change, bug fix, security fix, update)/boot
and/usr
size, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.