openstack/api: wait for image to be active #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2a1757e to
158b64d
Compare
krnowak
reviewed
Sep 23, 2022
platform/api/openstack/api.go
Outdated
| @@ -546,6 +546,18 @@ func (a *API) UploadImage(name, path string) (string, error) { | |||
| return "", fmt.Errorf("web uploading: %w", err) | |||
| } | |||
|
|
|||
| // It usually takes around 10 seconds to extract the image. | |||
| if err := util.WaitUntilReady(20*time.Second, 5*time.Second, func() (bool, error) { | |||
There was a problem hiding this comment.
I'd be on the safe side and would wait for a minute. :)
There was a problem hiding this comment.
Ok, let's do this!
krnowak
approved these changes
Sep 23, 2022
the image usually takes a few second to be unpacked on the Openstack instance. It can leads to CI error if the image used to run the test it not yet fully active. Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
adcf827 to
c9852de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the image usually takes a few second to be unpacked on the Openstack instance.
It can leads to CI error if the image used to run the test it not yet fully active.
Signed-off-by: Mathieu Tortuyaux mtortuyaux@microsoft.com