Skip to content

Commit

Permalink
azure: remove SAS URL generation
Browse files Browse the repository at this point in the history
This is not working at the moment and not used anymore with new Azure
automation.

Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
  • Loading branch information
tormath1 committed Aug 7, 2024
1 parent ac3b487 commit e46c085
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 16 deletions.
9 changes: 0 additions & 9 deletions cmd/plume/prerelease.go
Original file line number Diff line number Diff line change
Expand Up @@ -329,15 +329,6 @@ func azurePreRelease(ctx context.Context, client *http.Client, src *storage.Buck
if err != nil {
return err
}
sas, err := azure.SignBlob(client, container, blobName)
if err != nil {
plog.Fatalf("signing failed: %v", err)
}
url := azure.BlobURL(client, container, blobName)
plog.Noticef("Generated SAS: %q from %q for %q", sas, url, specChannel)
imageInfo.Azure = &azureImageInfo{
ImageName: sas, // the SAS URL can be used for publishing and for testing with kola via --azure-blob-url
}
}
return nil
}
Expand Down
7 changes: 0 additions & 7 deletions cmd/plume/release.go
Original file line number Diff line number Diff line change
Expand Up @@ -405,7 +405,6 @@ func doAzure(ctx context.Context, client *http.Client, src *storage.Bucket, spec

plog.Printf("Signing %q in %q on %v...", blobName, container, environment.CloudName)

var url string
blobExists, err := azure.BlobExists(client, container, blobName)
if err != nil {
plog.Fatalf("failed to check if blob %q in account %q container %q exists: %v", blobName, spec.Azure.StorageAccount, container, err)
Expand All @@ -415,12 +414,6 @@ func doAzure(ctx context.Context, client *http.Client, src *storage.Bucket, spec
plog.Notice("Blob does not exist, skipping.")
return
}
url, err = azure.SignBlob(client, container, blobName)
if err != nil {
plog.Fatalf("signing failed: %v", err)
}
plog.Noticef("Generated SAS: %q for %q", url, specChannel)
plog.Noticef("Please update the SKU manually (or try to automate this step)!")
}
}

Expand Down

0 comments on commit e46c085

Please sign in to comment.