Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CMake build #678

Merged
merged 2 commits into from
Dec 18, 2024
Merged

Fix CMake build #678

merged 2 commits into from
Dec 18, 2024

Conversation

ur4t
Copy link
Contributor

@ur4t ur4t commented Dec 18, 2024

No description provided.

@ur4t
Copy link
Contributor Author

ur4t commented Dec 18, 2024

This should fix #674.

@yzh119 @binhtranmcs

@ur4t ur4t marked this pull request as draft December 18, 2024 03:31
@ur4t ur4t changed the title Fix CMakeLists.txt Fix CMake build Dec 18, 2024
@ur4t ur4t marked this pull request as ready for review December 18, 2024 04:39
@ByronHsu
Copy link
Collaborator

I can verify this fixes the issue on my side

@zhyncs zhyncs merged commit caeb3d3 into flashinfer-ai:main Dec 18, 2024
@zhyncs
Copy link
Member

zhyncs commented Dec 18, 2024

Thanks!

@ur4t ur4t deleted the fix-cmake branch December 18, 2024 09:25
@binhtranmcs binhtranmcs mentioned this pull request Dec 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ur4t @ByronHsu @zhyncs