support versatile gqa size for batch prefill #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @xuzhenqi thanks so much for doing this, I'm refactoring the code to make group size a regular function argument instead of template parameter so that we can reduce the binary size. I'll notify you when the PR is ready list you as an co-author of that PR :) |
2 tasks
|
@yzh119 Do you have ETA on the dynamic group-size support? It may still be good to merge this PR if there no performance regressions, and then revert to the new solution when it is ready. The Yi-1.5 34B has hit the pipelines and I believe a lot more users will want to use this model even more so than Yi 1.0 34B. This PR covers that model and many others that do not fall in the statically compiled group_size slots. |
yzh119
added a commit
that referenced
this pull request
Jun 10, 2024
This reverts commit 3b3ce05. wip rebase wip wip upd upd remove macros that are no longer used upd upd upd bugfix 太阳,请赐予我完成它的力量吧 fix fix
yzh119
added a commit
that referenced
this pull request
Jun 10, 2024
This reverts commit 3b3ce05. wip rebase wip wip upd upd remove macros that are no longer used upd upd upd bugfix 太阳,请赐予我完成它的力量吧 fix fix remove redundant code
yzh119
added a commit
that referenced
this pull request
Jun 10, 2024
This reverts commit 3b3ce05. wip rebase wip wip upd upd remove macros that are no longer used upd upd upd bugfix 太阳,请赐予我完成它的力量吧 fix fix remove redundant code remove conflict
yzh119
added a commit
that referenced
this pull request
Jun 10, 2024
This reverts commit 3b3ce05. wip rebase wip wip upd upd remove macros that are no longer used upd upd upd bugfix 太阳,请赐予我完成它的力量吧 fix fix remove redundant code remove conflict
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge request supports versatile gqa size for batch prefill kernels. Group size 5, 6, 7, will be padded to group size 8 when loading q from global memory to shared memory, the padded groups will be discarded when writing o to global memory.